Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): move versioned_sidebars to static-assets #8743

Merged
merged 3 commits into from
Aug 30, 2023
Merged

feat(docs): move versioned_sidebars to static-assets #8743

merged 3 commits into from
Aug 30, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Aug 29, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This PR should be merged first. datahub-project/static-assets#50

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 29, 2023
@yoonhyejin yoonhyejin force-pushed the docs/versioned_sidebar branch from 791e3be to 80bb5dc Compare August 29, 2023 03:46
@yoonhyejin yoonhyejin marked this pull request as ready for review August 29, 2023 05:19
@yoonhyejin yoonhyejin requested a review from hsheth2 August 29, 2023 05:20
hsheth2
hsheth2 reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change needed but lgtm

docs-website/download_historical_versions.py Outdated Show resolved Hide resolved
hsheth2
hsheth2 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change needed but lgtm

hsheth2
hsheth2 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change needed but lgtm

@yoonhyejin yoonhyejin merged commit bebee88 into master Aug 30, 2023
37 of 38 checks passed
@yoonhyejin yoonhyejin deleted the docs/versioned_sidebar branch August 30, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2