Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confluent schema registry #7590

Closed
wants to merge 89 commits into from
Closed

Remove confluent schema registry #7590

wants to merge 89 commits into from

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

agilelab-tmnd1991 and others added 30 commits January 17, 2023 10:20
@agilelab-tmnd1991 @pedro93
feat(kafka): Remove Confluent Schema Registry
df56c9b
@pedro93
Try to fix module in Intellij
0caf750
@pedro93
Adds kafka serde classes and modifies java code to use them
244a968
@pedro93
fix checkstyle
bc1403f
@pedro93
Adds initial python work + spring bean cleanup
72d5821
@pedro93
Cleanup python code
6a9e78f
@pedro93
Fix java version requirements, python linting & test datahub-client t…
f4bc825 
…est requirements
@pedro93
Change lombok dependency
1f1b0cf
@pedro93
More fixes for slf4j
ee024ab
@pedro93
Add correct kafka module & move avro dependency to lower module
ce0100f
@pedro93
Adds OpenAPI definition for Confluent Schema Registry
5dc3f4f
@pedro93
Remove lombok from schema-registry-api module
3d61276
@pedro93
Make build pass
530ad1d
@pedro93
Adds schema registry open api implementation skeleton
a14f2b3
@pedro93
cleanup
e5d4c1d
@pedro93
Implement schema registry service
2e5ef0b
@pedro93
WIP integration test for openapi controller with full-blown kafka pro…
ac3ae5a 
…ducer/consumer
@pedro93
Update OpenAPI spec to v7.4.0 for correct return types + update test …
fba25f5 
…to use kafka consumers, still WIP
@pedro93
Finish test for MCLs & PEs
0d39178
@pedro93
rebase with master
a768a15
@pedro93
Remove Kafka avro serde module
9dd2a18
@pedro93
Update Docker dependencies, make test work
343855e
@pedro93
Cleanup code
6c57404
@pedro93
more code cleanup
53e1fd5
@pedro93
Fix KafkaEventConsumerFactory after rebase
ff9ce9a
@pedro93
Fix issues with linting & metadata-ingestion setup
9dc9b7a
@pedro93
modify docker compose files
df0a7a0
@pedro93
Fix python linters + integration test
d6a4e66
@pedro93
Fix mae consumer & add spring test for it
206099d
@pedro93
Add openapi servlet health controller & change onBootApplicationListe…
e32a46c 
…ner logic
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Mar 15, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 15, 2023
View reviewed changes
...ervlet/src/main/java/io/datahubproject/openapi/schema/registry/SchemaRegistryController.java
}

@Override
@Operation(summary = "", description = "", tags = { "Schema Registry Base" })

Check warning

Code scanning / QDJVMC

Default annotation parameter value

Redundant default parameter value assignment
...ervlet/src/main/java/io/datahubproject/openapi/schema/registry/SchemaRegistryController.java
}

@Override
@Operation(summary = "", description = "", tags = { "Schema Registry Base" })

Check warning

Code scanning / QDJVMC

Default annotation parameter value

Redundant default parameter value assignment
...ervlet/src/main/java/io/datahubproject/openapi/schema/registry/SchemaRegistryController.java

private final HttpServletRequest request;

@Qualifier("schemaRegistryService")

Check warning

Code scanning / QDJVMC

@Qualifier not copyable by lombok

Lombok does not copy the annotation 'org.springframework.beans.factory.annotation.Qualifier' into the constructor
@shirshanka shirshanka changed the title [Work in progress] Remove confluent schema registry Remove confluent schema registry Apr 18, 2023
@shirshanka shirshanka marked this pull request as ready for review April 18, 2023 03:13
@shirshanka
Copy link
Contributor Author

Closing as #7930 is merged already.

@shirshanka shirshanka closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shirshanka @agilelab-tmnd1991 @pedro93 @hsheth2 @RyanHolstien