feat(schema-registry): replace confluent schema registry #7930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use kafka consumers, still WIP
…gistry fix typo
…nt-schema-registry
…-schema-registry # Conflicts: # docker/kafka-setup/kafka-setup.sh # docker/quickstart/docker-compose-without-neo4j.quickstart.yml # docker/quickstart/docker-compose.quickstart.yml # docker/quickstart/generate_docker_quickstart.sh # metadata-integration/java/datahub-client/build.gradle
github-actions
bot
added
devops
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Override | ||
| @Operation(summary = "", description = "", tags = { "Schema Registry Base" }) |
Check warning
Code scanning / QDJVMC
Default annotation parameter value
| } | ||
|
|
||
| @Override | ||
| @Operation(summary = "", description = "", tags = { "Schema Registry Base" }) |
Check warning
Code scanning / QDJVMC
Default annotation parameter value
|
|
||
| private final HttpServletRequest request; | ||
|
|
||
| @Qualifier("schemaRegistryService") |
Check warning
Code scanning / QDJVMC
@Qualifier not copyable by lombok
david-leifker
changed the title
david-leifker
force-pushed
the
sd-remove-confluent-schema-registry
branch
from
a02f1df to
7ac77ad
Compare
david-leifker
force-pushed
the
sd-remove-confluent-schema-registry
branch
from
7ac77ad to
03df8e5
Compare
david-leifker
requested review from
RyanHolstien,
shirshanka,
pedro93 and
iprentic
RyanHolstien
approved these changes
May 1, 2023
| @@ -16,16 +17,17 @@ | |||
|
|
|||
|
|
|||
| @SpringBootTest(classes = { | |||
| MCLSpringTestConfiguration.class | |||
| MCLSpringTestConfiguration.class, ConfigurationProvider.class | |||
There was a problem hiding this comment.
Guessing this was the main change from the other PR?
There was a problem hiding this comment.
Some additional test beans, and the selection of the schema registry implementation in the test.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, confluent schema registry can be disabled and GMS act as the schema registry, however quickstart continues to use it. The helm chart update will allow both configurations. Quickstart will eventually remove it.
Checklist