feat(Kubernetes): Add JMX exporter containers to all DataHub components #2251
Conversation
|
@dexter-mh-lee : could you take a look? |
| @@ -74,6 +79,38 @@ spec: | |||
| {{- end }} | |||
| resources: | |||
| {{- toYaml .Values.resources | nindent 12 }} | |||
|
|
|||
| {{- if .Values.exporters.jmx.enabled }} | |||
| - name: jmx-exporter | |||
There was a problem hiding this comment.
Is it possible to extract this out into a library chart? https://helm.sh/docs/topics/library_charts/ Seems like a lot of the code needs to be copy and pasted
There was a problem hiding this comment.
Sure! I'll check that.
There was a problem hiding this comment.
Thanks for the contribution @bernardino, please let us know once you've been able to refactor this into a library chart. Looks great otherwise.
There was a problem hiding this comment.
It's running the build at the moment.
@dexter-mh-lee it looks waaay cleaner now! Thanks for your suggestion!
And I'm sorry for the delay.
bernardino
force-pushed
the
jmx-exporters
branch
from
666536a to
06fb81f
Compare
|
@bernardino There was a fix for the build issue that went in recently. The build error should go away once you merge latest master! |
bernardino
force-pushed
the
jmx-exporters
branch
from
06fb81f to
57d251c
Compare
|
Build is now green |
| java $JAVA_OPTS $JMX_OPTS \ | ||
| --jar jetty-util.jar \ |
There was a problem hiding this comment.
@bernardino This change is breaking prod. I think java only takes a single jar. Has this specific script been tested locally?
There was a problem hiding this comment.
I think I know what the error is, it should be
java $JAVA_OPTS $JMX_OPTS \
-jar /jetty-runner.jar \
--jar jetty-util.jar \
--jar jetty-jmx.jar \
/datahub/datahub-gms/bin/war.war
The --jar I added is for the jetty runner, it has nothing to do with the -jar, and in our custom run script in our helm charts the --jar options are after the runner.jar
Fixes #2214
Added JMX exporter container to Helm charts.
Also added JVM_OPTS and JMX_OPTS to such that it is easy to configure the JMX on the original container.
Checklist