Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose operational metrics #2214

Closed
pedro93 opened this issue Mar 11, 2021 · 2 comments · Fixed by #2251
Closed

Expose operational metrics #2214

pedro93 opened this issue Mar 11, 2021 · 2 comments · Fixed by #2251
Labels
feature-request Request for a new feature to be added

Comments

@pedro93
Copy link
Collaborator

pedro93 commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
Once datahub is deployed, regardless of method (docker-compose, K8s, bare-bones, etc...) there is no way to obtain metrics & alerts related to the health of the deployed components.
I.e: There is no endpoint I can poll to retrieve the health of GMS. Should it fail, I have no way to automate alerts to notify me.

Describe the solution you'd like
Given that DataHub is a mostly java project it should be relatively easy to expose JMX metrics such that they can then be consumed by a Prometheus instance or similar.
Ideally there should exist operational metrics for each component of Datahub with associated documentation on how to use it.
@pedro93 pedro93 added the feature-request Request for a new feature to be added label Mar 11, 2021
@shakti-garg
Copy link
Contributor

Agree for need of exposing JMX/Prometheus(which is widely used nowadays) metrics. For MCE and MAE, it is pretty-much out-of-box using Spring actuator APIs. For GMS also, can also be done using JMX exporter.

In case you agree it to be relevant for datahub, happy to contribute to this feature.

@pedro93
Copy link
Collaborator Author

pedro93 commented Mar 15, 2021

I think it is very relevant but I'm not a maintainer or contributor to the overall project. I simply created this issue as a request from a slack thread in the official channel.

@bernardino bernardino mentioned this issue Mar 18, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for a new feature to be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Kubernetes): Add JMX exporter containers to all DataHub components bernardino/datahub
2 participants
@pedro93 @shakti-garg