feat(ingestion): add execution log tab #13611

v-tarasevich-blitz-brain · 2025-05-23T11:14:23Z

DEPENDS ON #13614

codecov · 2025-05-29T13:12:39Z

Codecov Report

Attention: Patch coverage is 49.83819% with 620 lines in your changes missing coverage. Please review.

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error parsing JUnit XML in /home/runner/work/datahub/datahub/metadata-io/build/test-results/test/TEST-com.linkedin.metadata.graph.search.opensearch.SearchGraphServiceOpenSearchTest.xml at 117:1052

Caused by:
    RuntimeError: Error converting computed name to ValidatedString
    
    Caused by:
        string is too long
For more help, visit our troubleshooting guide.

Files with missing lines	Patch %	Lines
...eact/src/app/ingestV2/executions/ExecutionsTab.tsx	36.73%	93 Missing ⚠️
...ngestV2/shared/components/filters/SourceFilter.tsx	18.42%	93 Missing ⚠️
...hub-web-react/src/app/ingestV2/executions/utils.ts	30.85%	65 Missing ⚠️
...src/app/ingestV2/executions/components/Filters.tsx	31.46%	61 Missing ⚠️
...ingestV2/executions/components/ExecutionsTable.tsx	30.58%	59 Missing ⚠️
...V2/executions/components/columns/ActionsColumn.tsx	26.08%	34 Missing ⚠️
.../app/ingestV2/executions/components/EmptyState.tsx	43.39%	30 Missing ⚠️
...2/shared/components/filters/ExecutorTypeFilter.tsx	32.43%	25 Missing ⚠️
...tV2/executions/components/columns/SourceColumn.tsx	44.44%	20 Missing ⚠️
.../app/ingestV2/shared/components/UserWithAvatar.tsx	44.44%	20 Missing ⚠️
... and 17 more

❌ Your patch status has failed because the patch coverage (49.83%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

alwaysmeticulous · 2025-05-29T14:24:02Z

🔴 Meticulous spotted visual differences in 118 of 1430 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

_{Last updated for commit 3fd4fcd. This comment will update as new commits are pushed.}

codecov · 2025-05-29T16:04:26Z

Bundle Report

Changes will increase total bundle size by 7.79kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	19.66MB	7.79kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	7.79kB	16.03MB	0.05%

Files in assets/index-*.js:

./src/app/ingestV2/executions/components/ExecutionsTable.tsx → Total Size: 2.08kB
./src/app/ingestV2/executions/components/columns/SourceColumn.tsx → Total Size: 541 bytes
./src/app/ingestV2/constants.ts → Total Size: 87 bytes
./src/app/ingestV2/ManageIngestionPage.tsx → Total Size: 4.59kB
./src/app/ingestV2/shared/components/UserWithAvatar.tsx → Total Size: 565 bytes
./src/app/ingestV2/shared/components/columns/BaseActionsColumn.tsx → Total Size: 955 bytes
./src/app/ingestV2/executions/components/ExecutionDetailsModal.tsx → Total Size: 7.54kB
./src/app/ingestV2/executions/components/Filters.tsx → Total Size: 2.03kB
./src/app/ingestV2/executions/ExecutionsTab.tsx → Total Size: 3.73kB
./src/app/ingestV2/executions/components/reporting/StructuredReportItem.tsx → Total Size: 1.65kB
./src/app/ingestV2/executions/components/reporting/StructuredReportItemContext.tsx → Total Size: 1.0kB
./src/app/ingestV2/executions/components/columns/ActionsColumn.tsx → Total Size: 776 bytes
./src/app/ingestV2/executions/components/reporting/StructuredReport.tsx → Total Size: 1.15kB
./src/app/ingestV2/executions/components/reporting/StructuredReportItemList.tsx → Total Size: 804 bytes
./src/app/ingest/source/executions/IngestionExecutionTable.tsx → Total Size: 3.78kB
./src/app/ingestV2/executions/components/reporting/types.ts → Total Size: 395 bytes
./src/app/ingestV2/executions/hooks/useFilters.ts → Total Size: 798 bytes
./src/app/ingestV2/executions/components/EmptyState.tsx → Total Size: 1.35kB
./src/app/ingestV2/executions/components/columns/ExecutedByColumn.tsx → Total Size: 914 bytes
./src/app/ingestV2/executions/constants.ts → Total Size: 599 bytes
./src/app/ingestV2/executions/hooks/useRefresh.ts → Total Size: 238 bytes
./src/app/ingestV2/shared/components/RefreshButton.tsx → Total Size: 224 bytes
./src/app/ingestV2/executions/utils.ts → Total Size: 3.42kB

chriscollins3456

overall this is looking great! i have a few things that need to be handled but could be done in a followup. this PR is waiting on ones in front of it anyways

datahub-web-react/src/app/ingestV2/ManageIngestionPage.tsx

datahub-web-react/src/app/ingestV2/executions/ExecutionsTab.tsx

chriscollins3456 · 2025-05-29T22:01:22Z

datahub-web-react/src/app/ingestV2/executions/ExecutionsTab.tsx

+                <SourceContainer>
+                    <HeaderContainer>
+                        <StyledTabToolbar>
+                            <Filters onFiltersApplied={(newFilters) => setAppliedFilters(newFilters)} />


unfortunately it looks like the UI vs CLI filters aren't working properly right now for this tab

chriscollins3456

cool beans good stuff here

chriscollins3456 · 2025-05-30T23:48:58Z

metadata-models/src/main/pegasus/com/linkedin/execution/ExecutionRequestSource.pdl

-  @Searchable = {
-    "fieldName": "sourceType",
-    "fieldType": "KEYWORD",
-    "queryByDefault": false
-  }


why remove this searchable here? i know you just added it in the previous PR so i'm going to assume it's good to remove

I thought it could be used to filter system sources, but it turned out not to be the case. So I decided to remove it for now, as it is redundant.

chriscollins3456 · 2025-05-31T00:45:09Z

let's fix up these conflicts and see if we can bump up the test code coverage patch at all here before merge

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels May 23, 2025

vercel bot deployed to Preview May 23, 2025 11:31 View deployment

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from ba668fc to 9e5aea1 Compare May 29, 2025 13:09

github-actions bot deployed to datahub-wheels (Preview) May 29, 2025 13:20 View deployment

vercel bot had a problem deploying to Preview May 29, 2025 13:23 Failure

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from 9e5aea1 to b14df3b Compare May 29, 2025 13:50

github-actions bot deployed to datahub-wheels (Preview) May 29, 2025 13:55 View deployment

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from b14df3b to dde57cb Compare May 29, 2025 14:01

v-tarasevich-blitz-brain changed the title ~~[WIP] add executions tab on ingestion page~~ feat(ingestion): add execution log tab May 29, 2025

v-tarasevich-blitz-brain marked this pull request as ready for review May 29, 2025 14:06

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 29, 2025

github-actions bot deployed to datahub-wheels (Preview) May 29, 2025 14:13 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) May 29, 2025 14:23 View deployment

vercel bot had a problem deploying to Preview May 29, 2025 14:24 Failure

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from dde57cb to b1e8fcd Compare May 29, 2025 15:42

github-actions bot requested a deployment to datahub-wheels (Preview) May 29, 2025 15:44 Abandoned

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from b1e8fcd to 67267c0 Compare May 29, 2025 15:44

github-actions bot deployed to datahub-project-web-react (Preview) May 29, 2025 15:56 View deployment

github-actions bot deployed to datahub-wheels (Preview) May 29, 2025 15:56 View deployment

vercel bot had a problem deploying to Preview May 29, 2025 16:10 Failure

chriscollins3456 reviewed May 29, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 29, 2025

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from 67267c0 to f887c98 Compare May 30, 2025 13:54

datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 30, 2025

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from 713b099 to c8f1e5e Compare May 30, 2025 20:05

vercel bot had a problem deploying to Preview May 30, 2025 20:44 Failure

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from c8f1e5e to 6d1644a Compare May 30, 2025 20:53

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 30, 2025

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from 6d1644a to a1a7a90 Compare May 30, 2025 21:19

github-actions bot deployed to datahub-wheels (Preview) May 30, 2025 21:26 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 21:34 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 21:55 Failure

chriscollins3456 force-pushed the vt--add-executions-tab-on-ingestion-page branch from a1a7a90 to 01b24ce Compare May 30, 2025 23:48

github-actions bot deployed to datahub-wheels (Preview) May 30, 2025 23:51 View deployment

chriscollins3456 approved these changes May 30, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels May 31, 2025

github-actions bot deployed to datahub-project-web-react (Preview) May 31, 2025 00:01 View deployment

vercel bot had a problem deploying to Preview May 31, 2025 00:01 Failure

v-tarasevich-blitz-brain added 2 commits June 2, 2025 10:23

feat(ingestion): add execution log tab

0b32775

test(ingestion): add tests

b8ca42f

v-tarasevich-blitz-brain force-pushed the vt--add-executions-tab-on-ingestion-page branch from 01b24ce to b8ca42f Compare June 2, 2025 11:20

github-actions bot deployed to datahub-wheels (Preview) June 2, 2025 11:23 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 2, 2025 11:32 View deployment

vercel bot had a problem deploying to Preview June 2, 2025 11:34 Failure

test(ingestion): add BE tests

3fd4fcd

github-actions bot deployed to datahub-wheels (Preview) June 2, 2025 12:16 View deployment

github-actions bot deployed to datahub-project-web-react (Preview) June 2, 2025 12:26 View deployment

vercel bot had a problem deploying to Preview June 2, 2025 12:28 Failure

chriscollins3456 merged commit 5041677 into master Jun 2, 2025
76 of 80 checks passed

chriscollins3456 deleted the vt--add-executions-tab-on-ingestion-page branch June 2, 2025 14:47

kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025

feat(ingestion): add execution log tab (datahub-project#13611)

10fec5d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ingestion): add execution log tab #13611

feat(ingestion): add execution log tab #13611

Uh oh!

v-tarasevich-blitz-brain commented May 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 29, 2025 •

edited

Loading

Uh oh!

alwaysmeticulous bot commented May 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 29, 2025 •

edited

Loading

Assets Changed:

Uh oh!

chriscollins3456 left a comment

Uh oh!

Uh oh!

Uh oh!

chriscollins3456 May 29, 2025

Uh oh!

chriscollins3456 left a comment

Uh oh!

chriscollins3456 May 30, 2025

Uh oh!

v-tarasevich-blitz-brain Jun 2, 2025

Uh oh!

chriscollins3456 commented May 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(ingestion): add execution log tab #13611

feat(ingestion): add execution log tab #13611

Uh oh!

Conversation

v-tarasevich-blitz-brain commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

❌ Unsupported file format

Uh oh!

alwaysmeticulous bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chriscollins3456 May 29, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 commented May 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

v-tarasevich-blitz-brain commented May 23, 2025 •

edited

Loading

codecov bot commented May 29, 2025 •

edited

Loading

alwaysmeticulous bot commented May 29, 2025 •

edited

Loading

codecov bot commented May 29, 2025 •

edited

Loading