Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

rev the sdk min to 2.19.0-0 #99

Merged
merged 5 commits into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
sdk: [2.12.0, dev]
# TODO(devoncarew): Add `2.19.0` to this once that release is stable
sdk: [dev]
steps:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
- uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
## 1.1.0
## 1.1.0-dev

* Add `tryParseRadix`, `tryParseInt` and `tryParseHex` static methods
to both `Int32` and `Int64`.
* Document exception and overflow behavior of parse functions,
and of `toHexString`.
* Make `Int32` parse functions consistent with documentation (accept
leading minus sign, do not accept empty inputs).
* Update the minimum SDK constraint to 2.19.

## 1.0.1

* Switch to using `package:lints`.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: >-
repository: https://github.com/dart-lang/fixnum

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: '>=2.19.0-0 <3.0.0'

dev_dependencies:
lints: ^1.0.0
Expand Down
2 changes: 1 addition & 1 deletion test/int32_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ void main() {
expect(Int32(17), isNot(equals(Int64(16))));
expect(Int32.MIN_VALUE, isNot(equals(Int32.MAX_VALUE)));
expect(Int32(17), isNot(equals(18)));
expect(Int32(17) == 17, isTrue); // ignore: unrelated_type_equality_checks
expect(Int32(17) == 17, isTrue);
expect(Int32(17), isNot(equals(16)));
expect(Int32(17), isNot(equals(Object())));
expect(Int32(17), isNot(equals(null)));
Expand Down
7 changes: 3 additions & 4 deletions test/int64_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ void main() {
expect(Int64(0), isNot(equals(Int64(1))));
expect(Int64(0), equals(Int32(0)));
expect(Int64(0), isNot(equals(Int32(1))));
expect(Int64(0) == 0, isTrue); // ignore: unrelated_type_equality_checks
expect(Int64(0) == 0, isTrue);
expect(Int64(0), isNot(equals(1)));
expect(Int64(10), isNot(equals(Int64(11))));
expect(Int64(10), equals(Int64(10)));
Expand All @@ -398,12 +398,11 @@ void main() {
expect(Int64(10), equals(Int32(10)));
expect(Int64(10), isNot(equals(Int32(9))));
expect(Int64(10), isNot(equals(11)));
expect(Int64(10) == 10, isTrue); // ignore: unrelated_type_equality_checks
expect(Int64(10) == 10, isTrue);
expect(Int64(10), isNot(equals(9)));
expect(Int64(-10), equals(Int64(-10)));
expect(Int64(-10) != Int64(-10), false);
expect(
Int64(-10) == -10, isTrue); // ignore: unrelated_type_equality_checks
expect(Int64(-10) == -10, isTrue);
expect(Int64(-10), isNot(equals(-9)));
expect(largePos, equals(largePos));
expect(largePos, isNot(equals(largePosPlusOne)));
Expand Down