Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

rev the sdk min to 2.19.0-0 #99

Merged
merged 5 commits into from
Dec 8, 2022
Merged

rev the sdk min to 2.19.0-0 #99

merged 5 commits into from
Dec 8, 2022

Conversation

devoncarew
Copy link
Contributor

  • rev the sdk min to 2.19.0-0

This latest version of this package won't analyze cleanly for users (wrt the unrelated_type_equality_checks lint) without a fix for that lint in the 2.19.0 sdk. See also #97.

@devoncarew devoncarew marked this pull request as ready for review December 2, 2022 19:58
@devoncarew devoncarew requested a review from lrhn December 2, 2022 19:58
@devoncarew devoncarew marked this pull request as draft December 3, 2022 01:04
Copy link
Contributor

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devoncarew
Copy link
Contributor Author

Thanks! I'll land once we have a version (dev, beta) of 2.19 out w/ the updated lint.

@devoncarew
Copy link
Contributor Author

We did pick up this morning's dev release (2.19.0-444.0.dev), but it looks like it didn't include the linter fix.

@devoncarew
Copy link
Contributor Author

Looks like it'll be in 2.19.0-450.0.dev and later.

@mit-mit mit-mit marked this pull request as ready for review December 8, 2022 15:31
@devoncarew devoncarew merged commit 3bd726f into master Dec 8, 2022
@devoncarew devoncarew deleted the update_sdk_min branch December 8, 2022 15:38
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 15, 2024
* rev the sdk min to 2.19.0-0

* remove localy use of ignore: unrelated_type_equality_checks

* remove localy use of ignore: unrelated_type_equality_checks

* Tweak constraint

* Revert previous commit

Co-authored-by: Michael Thomsen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants