Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Change IntegerDivisionByZeroException to UnsupportedError #100

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Dec 8, 2022

Contributes to dart-lang/sdk#49529

@mit-mit
Copy link
Contributor Author

mit-mit commented Dec 8, 2022

This will need #99 to get tests to pass

@mit-mit mit-mit requested review from lrhn and jakemac53 December 8, 2022 16:09
@mit-mit mit-mit changed the title Change DivZeroExp. to UnsupportedError Change IntegerDivisionByZeroException to UnsupportedError Dec 8, 2022
@mit-mit
Copy link
Contributor Author

mit-mit commented Dec 8, 2022

@jakemac53 any chance you could help with a roll too after this lands?

@mit-mit mit-mit enabled auto-merge (squash) December 8, 2022 16:11
@jakemac53
Copy link
Contributor

jakemac53 commented Dec 8, 2022

This one will roll automatically with the Dart SDK - so it just needs to be updated in DEPS there, which I think might also happen automatically nowadays, cc @devoncarew can confirm.

@mit-mit mit-mit merged commit e4f5e97 into dart-archive:master Dec 8, 2022
@mit-mit mit-mit deleted the removeintdivzeroexp branch December 9, 2022 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants