If you have ever tested the changes in real world Cloudflare Workers Environment, you will notice that it will break a lot of things and cause inconsistent behaviors.

You really shouldn't try to modify the test to suit your changes.

You really shouldn't try to modify the test to suit your changes.

The tests were modified to support the new global scoping of __STATIC_CONTENT via the various mocks that are done to create an environment for "testing". Previously, index.ts didn't reference any globals like __STATIC_CONTENT until inside of a function scope, and thus the mocks were fine, but now with this being parsed in the global scope, the mocks (and more specifically when they run) needed to be modified to support this.

As far as I can see, there is no other way to implement this performance boost by only parsing it once without modifying the tests, as this change very intentionally moves these globals into the global scope, so that they're only parsed once.

If you have ever tested the changes in real world Cloudflare Workers Environment, you will notice that it will break a lot of things and cause inconsistent behaviors.

I'm interested to hear any more details here. I did test this with wrangler dev as well as published worker, and things were working just fine. Could you provide any more specific information?

no update here @Cherry so I think we're good to merge!

no update here @Cherry so I think we're good to merge!

Will do! I'll do one final round of testing this week (I'm a little nervous about this one as per the comments here, even if I haven't found any issues myself) and then merge in a few days. 👍

I did some final testing of this with 2 different sites, both via wrangler dev and a staging publish to workers.dev, without any issues at all. Merging for now, and if any issues are found we can revisit.