This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Fixes issue #139 - Only parse ASSET_MANIFEST once on isolate startup
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate startup
Contributor
|
LGTM! Could you provide any benchmark result or real time performance data for the PR? For example: /* index.js */
// ...
let BEGIN_TIME, END_TIME;
addEventListener('fetch', event => {
BEGIN_TIME = Date.now();
event.respondWith(handleEvent(event));
})
async function handleEvent(event) {
// ...
const response = await getAssetFromKV(event, kvOptions);
END_TIME = Date.now();
if (typeof BEGIN_TIME === 'number' && typeof END_TIME === 'number') {
response.headers.append('x-kv-time', `resp:${END_TIME - BEGIN_TIME}ms`);
}
return response
}And see if |
Author
|
Sure! I've ran the following code with a couple of different iteration-counts. Hope that's ok. import fetch from 'node-fetch'
const iterations = 1000
const url = '' // Url to single resource
let sum = 0
const runTest = async () => {
for(let k = 0; k < iterations ; k++) {
const response = await fetch(url)
if(!response.ok) throw new Error('Response was not ok!')
const timeHeaders = response.headers.get('x-kv-time');
const first = Array.isArray(timeHeaders) ? timeHeaders[0] : timeHeaders
const number = parseInt(first.replace('ms', ''), 10)
sum += number
}
}
runTest().then(() => {
console.log('Done. Mean kv response time is ' + sum / iterations)
})Before change: (Edit: had to run this again. Forgot to remove a yarn link before publishing) After change |
harrishancock
approved these changes
Aug 17, 2020
harrishancock
left a comment
harrishancock
left a comment
There was a problem hiding this comment.
Makes sense to me. Thanks, @groenlid!
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #139 where ASSET_MANIFEST is parsed on each call to getAssetFromKV.
I'm currently using this library for a medium to large gatsby project (734MB over 53232 files) and this change would improve our performance quite a bit.