Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results visualization: add possibility to hide lines #402

Open
acomodi opened this issue Apr 13, 2022 · 9 comments
Open

Results visualization: add possibility to hide lines #402

acomodi opened this issue Apr 13, 2022 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@acomodi
Copy link
Contributor

acomodi commented Apr 13, 2022

At the moment there is no possibility to hide the lines in the charts corresponding to the various toolchains.

Screenshot from 2022-04-13 09-16-09

The idea is to be able to click on the colored line belonging to a particular toolchain and disable all the lines corresponding to the particular toolchain.

For context, the results directory contains the code to gather and generate the HTML representation of all the results produced by the FPGA tool perf CI.

@acomodi acomodi added the good first issue Good for newcomers label Apr 13, 2022
@SiyaoIsHiding
Copy link

I would love to contribute to this issue :D. May u assign this issue to me?

@SiyaoIsHiding
Copy link

@acomodi Just in case u didn't receive the notification

@kgugala
Copy link
Member

kgugala commented Mar 18, 2023

Hi @SiyaoIsHiding I've assigned the issue to you

@SiyaoIsHiding
Copy link

@kgugala & @acomodi,
Hello, I am working on this issue.

May I ask what should I put into the environment variable RESULTS_DIR when I build the visualization?
The only clue I found is the CI file

      - name: Use gcloud CLI
        run: |
          cd results
          mkdir build-results
          gsutil cp gs://${{ secrets.GCP_STORAGE_BUCKET }}/*.json.gz build-results

But I do not have the access to your gcloud so I still don't know what I should put into this build-results folder.

Besides, may you simply give me an example of this build-results folder so that I can test the JS codes? I probably only need to modify the JS script inside the result folder, so I do not need to reproduce all your environment.

Thank you for your time and any advice will be appreciated.

Best,
Jane

@tmichalak
Copy link
Collaborator

Hi @SiyaoIsHiding, thanks for looking into this issue. Let me take a look and get back to you.

@tmichalak
Copy link
Collaborator

@SiyaoIsHiding so actually for the purpose of solving this issue you could simply generate the data source files using the exhaust script, copy the resulting *.json.gz to the created build-results directory and run make preprocess and make build in the results directory.
However, for simplicity I am uploading two *.json.gz files with the latest results. Copy them to the build-results directory and run the process and build targets.
results-20230320-165233.json.gz
results-20230320-085242.json.gz

@SiyaoIsHiding
Copy link

Thank you very much. I will work on it immediately.

@palaniappan-r
Copy link

Hi, if the issue is still open, can I pick this up?

@SiyaoIsHiding
Copy link

yeah sure pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants