Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is broken in a number of ways? #328

Open
mithro opened this issue Jul 2, 2021 · 4 comments · Fixed by #329
Open

CI is broken in a number of ways? #328

mithro opened this issue Jul 2, 2021 · 4 comments · Fixed by #329

Comments

@mithro
Copy link
Collaborator

mithro commented Jul 2, 2021

https://source.cloud.google.com/results/invocations/88d65c97-05ba-4d83-9a8d-79fbd40f31c1/targets/foss-fpga-tools%2Ffpga-tool-perf%2Fcontinuous/log
@acomodi acomodi mentioned this issue Jul 5, 2021
Merged
@mithro mithro reopened this Jul 7, 2021
@mithro
Copy link
Collaborator Author

mithro commented Jul 7, 2021

@acomodi Do you know if FPGA Perf tool has "allowed failures" and making sure things don't regress?

@acomodi
Copy link
Contributor

acomodi commented Jul 7, 2021

@mithro CI works in a way that all the possible toolchain/devices/designs are tested. It is expected that some of them won't build successfully, and there are combinations which have to pass, and if they fail, the build fails as well.
Take the following for instance: https://github.com/SymbiFlow/fpga-tool-perf/blob/9f5850793ad98f98101792fa3564e894bf60aa1f/project/baselitex.json#L19

If any of the required toolchain fail, the build will be considered failed as well.

@mithro
Copy link
Collaborator Author

mithro commented Jul 7, 2021

Okay great, we definitely want to make sure that things we care about are not regressing.

@mithro
Copy link
Collaborator Author

mithro commented Jul 7, 2021

Can we get links posted in the CI and the dashboards linked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing CI antmicro/fpga-tool-perf
2 participants
@mithro @acomodi