Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PaletteSelect use stylehseets instead of inline styles #14052

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Sep 5, 2024

This PR improves internals of PaletteSelect widget in preparation for adding support for vertical select widgets and generalizing the implementation to generic selects.

@mattpap mattpap added this to the 3.6 milestone Sep 5, 2024
@mattpap mattpap force-pushed the mattpap/palette_select_stylesheets branch 2 times, most recently from 109fc5c to 46865d6 Compare September 5, 2024 12:46
@mattpap mattpap force-pushed the mattpap/palette_select_stylesheets branch from 46865d6 to e7af554 Compare September 5, 2024 13:46
Copy link
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one typo

@mattpap mattpap force-pushed the mattpap/palette_select_stylesheets branch from e7af554 to a8ec93b Compare September 6, 2024 17:51
@mattpap mattpap merged commit 4f93515 into branch-3.6 Sep 6, 2024
21 of 22 checks passed
@mattpap mattpap deleted the mattpap/palette_select_stylesheets branch September 6, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants