Have StringFormatter respect nan_format #14017
Conversation
|
Well, presumably the |
|
@mattpap how can I run individual or subsets of BokehJS tests? |
|
It looks like Edit: honestly I rather think |
E.g. |
|
Agree with |
Yes, that makes sense to me as well. |
@philippjfr Just clarifying, do you mean the new default for just |
|
I split out |
| value = this.nan_format | ||
| } else if (value == null) { | ||
| value = this.null_format | ||
| } |
There was a problem hiding this comment.
FWIW I think this is slightly awkward with the other formatters inheriting from StringFormatter, since they also do the same checks and then often call super.doFormat.
That said, things already seem a bit vague here: e.g. is StringFormatter a formatter for string value inputs or a formatter that formats anything, to string values? In seems like a name more likeTextPropertiesFormatter would be more descriptive here.
* Have StrinFormatter respect nan_format * split off null_format * update defaults
nan_formatseems broken #14014