wallet: Translate [default wallet] string in progress messages #31296
Conversation
Noticed while reviewing bitcoin#31287 (bitcoin#31287 (comment)) that the [default wallet] part of progress messages remains untranslated while the rest of the string is translated. Fix this in all places where Wallet::ShowProgress (which has a cancel button) and chain::showProgress (which doesn't have a cancel button) are called by making "default wallet" into a translated string. To minimize scope of this bugfix, this introduces a new wallet DisplayName() method which behaves differently than the existing GetDisplayName() method. The existing method will be cleaned up in the following commit.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31296. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK. |
|
What are the steps to test this with sqlite? If it isn't needed after the bdb removal, it can probably be skipped? |
The GetDisplayName() method name was confusing because it suggested the return value could be used for display, while documentation and implementation indicated it only meant to be used for logging. Also the name didn't suggest that it was formatting the wallet names, which made it harder understand how messages were formatted in the places it was called. Fix these issues by splitting up the GetDisplayName() method and replacing it with LogName() / DisplayName() methods. This commit is a refactoring that does not change any behavior.
|
re: #31296 (comment)
Not sure if this will always be the case, but it is currently possible to create an sqlite wallet with no name with Regardless of the details of the bug though, I think the real problem is that the Updated 87152db -> ebb77ab ( |
Noticed while reviewing #31287 (comment) that the [default wallet] part of progress messages remains untranslated while the rest of the string is translated.
Fix this in all places where
CWallet::ShowProgress(which has a cancel button) andChain::showProgress(which doesn't have a cancel button) are called by making "default wallet" into a translated string.