Remove the legacy wallet and BDB dependency #28710
Draft
+1,181
−12,105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/28710. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
achow101
force-pushed
the
rm-legacy-wallet
branch
from
d642e26 to
ad3080c
Compare
46 tasks
achow101
force-pushed
the
rm-legacy-wallet
branch
from
ad3080c to
fcc606a
Compare
This was referenced Oct 24, 2023
Closed
Merged
Salvage is bdb only which is about to be removed.
We can't load legacy wallet anymore, so if migration fails, don't try to load the failed wallet.
Require sqlite is available in order to compile the wallet. Removes instances of USE_SQLITE since it is no longer possible to not have sqlite available.
Legacy wallets do not have the descriptors flag set. Don't load wallets without the descriptors flag. At the same time, we will no longer load BDB databases since they are only used for legacy wallets.
This function will be needed in migration
Instead of (partially) trying to reverse IsMine() to get the output scripts that a LegacySPKM would track, we can preserve it in migration only code and utilize it to get an accurate set of output scripts. This is accomplished by computing a set of output script candidates from map(Crypted)Keys, mapScripts, and setWatchOnly. This candidate set is an upper bound on the scripts tracked by the wallet. Then IsMine() is used to filter to the exact output scripts that LegacySPKM would track. By changing GetScriptPubKeys() this way, we can avoid complexities in reversing IsMine() and get a more complete set of output scripts.
InferDescriptors can sometimes make descriptors which are actually invalid and cannot be parsed. Detect and skip such descriptors by doing a Parse() check before adding the descriptor to the wallet.
LegacySPKM would determine whether it could provide any script data to a transaction through the use of the CanProvide function. Instead of partially reversing signing logic to figure out the output scripts of solvable things, we use the same candidate set approach in GetScriptPubKeys() and instead filter the candidate set first for things that are ISMINE_NO, and second with CanProvide(). This should give a more accurate solvables wallet.
achow101
force-pushed
the
rm-legacy-wallet
branch
from
77604d6 to
449353a
Compare
The legacy wallet will be able to solve output scripts where the redeemScript or witnessScript is known, but does not know any of the private keys involved in that script. These should be migrated to the solvables wallet.
achow101
force-pushed
the
rm-legacy-wallet
branch
from
449353a to
3351001
Compare
Deletes LegacyScriptPubKeyMan and related tests
SOme db functions were for BDB, these are no longer needed.
achow101
force-pushed
the
rm-legacy-wallet
branch
from
3351001 to
e6ccd17
Compare
This was referenced Dec 16, 2024
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final step of #20160.
A bare minimum of legacy wallet code is kept in order to perform wallet migration. Migration of legacy wallets uses the independent BDB parser and a minimal
LegacyDataSPKMthat allows the legacy data to be loaded so that the migration can be completed.All tests which tested legacy wallet behavior have been removed. The
--descriptorsand--legacy-walletoptions are removed from the functional tests.BDB has been removed as a dependency and documentation have been updated to reflect that.
Depends on #26596, bitcoin-core/gui#824, #30265, #30328, and #31250