Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Babel 8] Remove DecimalLiteral AST #16807

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[Babel 8] Remove DecimalLiteral AST #16807

merged 2 commits into from
Sep 5, 2024

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? #16741
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: types Spec: Decimal labels Sep 5, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 5, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57848

@liuxingbaoyu
Copy link
Member Author

We already have a migration document for removing the decimal plugin, do we need to explain removing DecimalLiteral?

@nicolo-ribaudo
Copy link
Member

I would just mention that it's removed and nothing else.

@nicolo-ribaudo nicolo-ribaudo merged commit 0a55713 into babel:main Sep 5, 2024
52 checks passed
@fisker fisker mentioned this pull request Sep 8, 2024
Merged
4 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release Spec: Decimal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung