[Babel 8] Remove decimal from parser
#16741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57826 |
liuxingbaoyu
force-pushed
the
remove-decimal
branch
from
9a16dc2 to
2e86def
Compare
|
Could we throw a more helpful error? Either in https://github.com/babel/babel/blob/main/packages/babel-parser/src/plugin-utils.ts when the plugin is enabled, or in the tokenizer when we see |
liuxingbaoyu
force-pushed
the
remove-decimal
branch
from
fd8fdd3 to
22ec593
Compare
7 tasks
JLHwung
reviewed
Aug 31, 2024
| "BABEL_8_BREAKING": true, | ||
| "throws": "Identifier directly after number. (1:2)" | ||
| } |
There was a problem hiding this comment.
Since Babel 8 no longer supports parsing 0.1m and it is not expected to throw missing plugin error, we can just remove this case.
JLHwung
reviewed
Aug 31, 2024
JLHwung
reviewed
Aug 31, 2024
JLHwung
reviewed
Aug 31, 2024
| @@ -26,6 +26,8 @@ if [ "$BABEL_8_BREAKING" = true ] ; then | |||
| sed -i 's/const getChalk = () => chalk/default (code) => code/' scripts/build/shims/babel-highlight.js | |||
| sed -i 's/const generate = babelGenerator.default/const generate = babelGenerator/' scripts/build/transform/index.js | |||
| rm tests/unit/__snapshots__/visitor-keys.js.snap | |||
| sed -i 's/"decimal",//' src/language-js/parse/babel.js | |||
| rm tests/format/js/babel-plugins/decimal.js | |||
nicolo-ribaudo
approved these changes
Sep 3, 2024
JLHwung
approved these changes
Sep 3, 2024
nicolo-ribaudo
force-pushed
the
remove-decimal
branch
from
5d54f64 to
152769a
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will open a follow up PR to remove AST.