fix(utils): Changed to be able to refer to default settings proposed … #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from: #972 (comment) If i want to add new settings based on default setting, i can just pass in a table, i.e. settings["lsp_deps"] = {
"bashls",
"clangd",
"html",
"jsonls",
"lua_ls",
"pylsp",
"zls", -- zig lsp
}If i want to replace/remove some default settings, i need to pass in a function, i.e. settings["lsp_deps"] = function()
return {
"lua_ls",
"pylsp",
"zls", -- zig lsp
}
endDid I missing understanding anything? |
|
The override method is fine |
|
aha, got it. So for referring default settings and adding new settings: local default_setting = require("core.settings")
settings["lsp_deps"] = function(default_settings.lsp_deps)
return {
"zls", -- zig lsp
}
endFor rewriting default settings: settings["lsp_deps"] = function()
return {
"lua_ls",
"pylsp",
"zls", -- zig lsp
}
endam i right? |
|
The suggestion is to leave room for users to do their own merges. settings["lsp_deps"] = {
"bashls",
"clangd",
"html",
"jsonls",
"lua_ls",
"pylsp",
}We can change the settings as follows. (use
settings["lsp_deps"] = {
"zls", -- zig lsp
}
-- Return:
-- {
-- "bashls",
-- "clangd",
-- "html",
-- "jsonls",
-- "lua_ls",
-- "pylsp",
-- "zls"
-- }
settings["lsp_deps"] = function(default)
return {
default[5] -- "lua_ls"
default[6] -- "pylsp"
"zls", -- zig lsp
}
end
-- default:
-- {
-- "bashls",
-- "clangd",
-- "html",
-- "jsonls",
-- "lua_ls",
-- "pylsp",
-- }
-- Return:
-- {
-- "lua_ls",
-- "pylsp",
-- "zls"
-- }
-- Override bufferline
return function(default)
return {
options = {
number = nil,
...
color_icons = default.options.color_icons, -- reference default opt
}
}
end
-- default:
-- options = {
-- number = nil,
-- modified_icon = icons.ui.Modified,
-- buffer_close_icon = icons.ui.Close,
-- ...
--} |
|
tks for the explanations! |
ayamir
approved these changes
Aug 28, 2023
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Aug 29, 2023
ttbug
pushed a commit
to ttbug/nvimconf
that referenced
this pull request
Aug 29, 2023
leavers
pushed a commit
to leavers/nvimdots
that referenced
this pull request
Aug 31, 2023
ImAaronChou
pushed a commit
to ImAaronChou/nvimdots
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to be able to refer to default settings from
extend_configandload_pluginfunctions proposed in #972