Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ecs): add security groups from the ASG's connections into the ECS Cluster's connection when using addAsgCapacityProvider #26176

Closed
wants to merge 67 commits into from
Closed

chore(ecs): add security groups from the ASG's connections into the ECS Cluster's connection when using addAsgCapacityProvider #26176

wants to merge 67 commits into from

Conversation

KollaAdithya
Copy link
Contributor

Automatically add security groups from the ASG's connections into the ECS Cluster's connection when using addAsgCapacityProvider.

const myCapacityProvider = new ecs.AsgCapacityProvider(this, 'MyCapacityProvider', {
    autoScalingGroup: myAsg,
});
myCluster.addAsgCapacityProvider(myCapacityProvider);

homakk and others added 30 commits February 17, 2023 21:26
@homakk
Modified packages
ee612a4
@homakk
Merge branch 'main' of github.com:homakk/aws-cdk
a289cdb
@homakk
chore: Configureautoscaling calling autoscaling connections securityg…
ad69473 
…roups in the Cluster
@homakk
Merge branch 'main' of https://github.com/homakk/aws-cdk
0e87811
@homakk
chore: Configureautoscaling calling autoscaling connections securityg…
aefd1dc 
…roups in the Cluster
@homakk
Merge branch 'autoscalingconnections' of https://github.com/homakk/aw…
2847d5b 
…s-cdk into autoscalingconnections
@homakk
revert changes of Feature_flags.md file
f91c86d
@homakk
added feature flag and modifed code
e40cc63
@homakk
feature flag file
3f18efc
@homakk
updated feature flag name and version
47de80f
@homakk
updated feature flag and reverted integ changes
6697911
@Naumel
Merge branch 'main' into autoscalingconnections
a910605
@homakk
updated integ file with snapshots
b9bae59
@homakk
Merge branch 'autoscalingconnections' of https://github.com/homakk/aw…
2be1d05 
…s-cdk into autoscalingconnections
@rix0rrr @homakk
chore(cli-integ): add per-test timeouts (aws#24504)
42074bb 
We couldn't use the jest timeout feature for our integration tests, and ended up running without timeouts.

This made it EXTREMELY hard to debug an issue where the tests ended up not finishing, and not producing any output to indicate why.

Re-add the ability to have timeouts on test, and set a timeout of 10 minutes on all of them.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@RomainMuller @homakk
chore: remove parentheses in 'sam local start-api' filter (aws#24508)
6529e77 
The dependencies in v1.76.0+ of the SAM CLI no longer contain parenthesis in the output, making the trigger wait forever
@RomainMuller @homakk
chore: print message if tests run concurrently
039f9c3
@mergify
Merge branch 'main' into autoscalingconnections
4321ff4
@homakk
updated test case making new feature flag to be true
1424564
@homakk
merge main into autoscaling
a4f3e72
@homakk
updates changes
0366bd4
@homakk
making default to false for feature flag
868b85e
@homakk
removing default and trying for build pass
19ceea4
@homakk
upddating testcase
ab87b71
@homakk
setting default to false
473c167
@bvtujo
chore: fix ec2 service intex test
d5132eb
@bvtujo
test: fix outdated/failing commandAndEntrypoint test
357d7ab
@bvtujo
chore: fix typo in integ test
fcf3147
@Naumel @homakk
fix: Correct SamlConsolePrincipal for non-China (aws#24277)
90d1ac0 
Closes aws#24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@homakk
Merge remote-tracking branch 'upstream/main'
5734dc2
@gitpod-io
Copy link

gitpod-io bot commented Jun 30, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 30, 2023 05:11
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 30, 2023
@mergify mergify bot mentioned this pull request Jun 30, 2023
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 15c9ad2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

7 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@KollaAdithya @aws-cdk-automation @homakk @Naumel @rix0rrr @RomainMuller @bvtujo @corymhall