chore(cli-integ): add per-test timeouts #24504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We couldn't use the jest timeout feature for our integration tests, and ended up running without timeouts. This made it EXTREMELY hard to debug an issue where the tests ended up not finishing, and not producing any output to indicate why. Re-add the ability to have timeouts on test, and set a timeout of 10 minutes on all of them.
RomainMuller
approved these changes
Mar 8, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 9, 2023
We couldn't use the jest timeout feature for our integration tests, and ended up running without timeouts. This made it EXTREMELY hard to debug an issue where the tests ended up not finishing, and not producing any output to indicate why. Re-add the ability to have timeouts on test, and set a timeout of 10 minutes on all of them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 28, 2023
We couldn't use the jest timeout feature for our integration tests, and ended up running without timeouts. This made it EXTREMELY hard to debug an issue where the tests ended up not finishing, and not producing any output to indicate why. Re-add the ability to have timeouts on test, and set a timeout of 10 minutes on all of them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't use the jest timeout feature for our integration tests, and ended up running without timeouts.
This made it EXTREMELY hard to debug an issue where the tests ended up not finishing, and not producing any output to indicate why.
Re-add the ability to have timeouts on test, and set a timeout of 10 minutes on all of them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license