Skip to content

bug: switch to integer for the skip flag #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fedorov merged 2 commits into from
Jun 19, 2024
Merged

bug: switch to integer for the skip flag #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5ba16
bug: switch to integer for the skip flag
fedorov Jun 19, 2024
bc19b0d
test: update test to account for changed behavior of the parameter
fedorov Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeExternals/SlicerExecutionModel.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ if(NOT DEFINED SlicerExecutionModel_DIR AND NOT ${CMAKE_PROJECT_NAME}_USE_SYSTEM

ExternalProject_SetIfNotDefined(
${proj}_REVISION_TAG
"62d0121dbb0fb057ebbd7c9ab84520accacec8bc"
"4325526343f582dd2080d0ffd93a63c8817dfb95"
QUIET
)

Expand Down
1 change: 1 addition & 0 deletions apps/seg/Testing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ foreach(seg_size ${TEST_SEG_SIZES})
--inputImageList ${BASELINE}/${seg_size}/nrrd/label.nrrd
--inputDICOMDirectory ${BASELINE}/${seg_size}/image
--outputDICOM ${MODULE_TEMP_DIR}/${seg_size}_seg.dcm
--skip 0
)

dcmqi_add_test(
Expand Down
6 changes: 3 additions & 3 deletions apps/seg/itkimage2segimage.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@
<parameters advanced="true">
<label>Advanced processing parameters</label>

<boolean>
<integer>
<name>skipEmptySlices</name>
<label>Skip empty slices</label>
<channel>input</channel>
<longflag>skip</longflag>
<default>true</default>
<default>1</default>
<description>Skip empty slices while encoding segmentation image. By default, empty slices will not be encoded, resulting in a smaller output file size.</description>
</boolean>
</integer>

<boolean>
<name>useLabelIDAsSegmentNumber</name>
Expand Down