Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: switch to integer for the skip flag #499

Merged
merged 2 commits into from
Jun 19, 2024
Merged

bug: switch to integer for the skip flag #499

merged 2 commits into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. bug: switch to integer for the skip flag 

    re #498

It appears that defaults are ignored for boolean SEM parameters. Even though
the parameter was set to true in https://github.com/QIICR/dcmqi/blob/2990dbd01d1fa61c16777950732ff19dc87318e3/apps/seg/itkimage2segimage.xml#L58-L65,
the default reported by the executable was 0.

Local tests show that integer parameters do not have this problem.

Also switch to the most recent has for SlicerExecutionModel.
    @fedorov
    fedorov committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4d5ba16 View commit details
    Browse the repository at this point in the history

  2. test: update test to account for changed behavior of the parameter

    @fedorov
    fedorov committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    bc19b0d View commit details
    Browse the repository at this point in the history