Add download_asset to GitReleaseAsset
#2624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits are useful to review independently. |
thejcannon
force-pushed
the
jcannon/download_assets
branch
from
61276b6 to
11978ba
Compare
|
On second thought. Meh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
download_assettoGitReleaseAssetto close the gap on missing functionality.Unfortunately, the current code isn't designed to handle this use-case so some refactoring was necessary. The changes should only be to private methods/attributes. Ideally, the
RequestsResponseobject was handed around more freely, but I didn't want to break any public-facing APIs.Fixes #2445