Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Release Asset? #2445

Open
neel-m opened this issue Mar 3, 2023 · 1 comment · May be fixed by #3060
Open

Download Release Asset? #2445

neel-m opened this issue Mar 3, 2023 · 1 comment · May be fixed by #3060

Comments

@neel-m
Copy link

neel-m commented Mar 3, 2023

Can't reopen #1541 and my post to it doesn't seem to be attracting any attention.

It seems like the ability to download a release asset would be a good thing. Here is what I think it needs:

  1. Add the function download_asset(self, path) to GitReleaseAsset.py (and .pyi). This function just calls requestFile() in its _requester object.
  2. Add the implementation of requestFile(self, verb, url, parameters, cnx, path) to Requester.py (and.pyi).

For this particular function verb, parameters, and cnx are not really needed. The other functions in GitReleaseAsset don't seem to be passing in cnx and just get a new one from the requester. The verb isn't really needed for this function, but might be needed for something in the future?

Not really sure what else I might be missing. Is there anyone willing to do a review of a PR?

@neel-m
Copy link
Author

neel-m commented Mar 13, 2023

So, no interest in this at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant