You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can't reopen #1541 and my post to it doesn't seem to be attracting any attention.
It seems like the ability to download a release asset would be a good thing. Here is what I think it needs:
Add the function download_asset(self, path) to GitReleaseAsset.py (and .pyi). This function just calls requestFile() in its _requester object.
Add the implementation of requestFile(self, verb, url, parameters, cnx, path) to Requester.py (and.pyi).
For this particular function verb, parameters, and cnx are not really needed. The other functions in GitReleaseAsset don't seem to be passing in cnx and just get a new one from the requester. The verb isn't really needed for this function, but might be needed for something in the future?
Not really sure what else I might be missing. Is there anyone willing to do a review of a PR?
The text was updated successfully, but these errors were encountered:
Can't reopen #1541 and my post to it doesn't seem to be attracting any attention.
It seems like the ability to download a release asset would be a good thing. Here is what I think it needs:
download_asset(self, path)
to GitReleaseAsset.py (and .pyi). This function just calls requestFile() in its _requester object.requestFile(self, verb, url, parameters, cnx, path)
to Requester.py (and.pyi).For this particular function verb, parameters, and cnx are not really needed. The other functions in GitReleaseAsset don't seem to be passing in cnx and just get a new one from the requester. The verb isn't really needed for this function, but might be needed for something in the future?
Not really sure what else I might be missing. Is there anyone willing to do a review of a PR?
The text was updated successfully, but these errors were encountered: