Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cythonify lite functions #2256

Closed
wants to merge 9 commits into from
Closed

Conversation

namurphy
Copy link
Member

This is a prototype for converting the lite-functions from Numba to Cython.

@namurphy namurphy added the prototype 🏗️ Trying out an implementation on a trial basis label Jul 26, 2023
@github-actions github-actions bot added the requirements Related to updating requirements label Jul 26, 2023
@github-actions
Copy link

Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱

Our contributor guide has information on:

The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:

  • Try fixing CI / Python 3.11 test failures first.
  • Most pre-commit.ci - pr failures can be automagically fixed by commenting pre-commit.ci autofix below, followed by a git pull to bring the changes back to your computer.
  • If pre-commit.ci - pr says that a function is too long or complex, try breaking up that function into multiple short functions that each do one thing. See also these tips on writing clean scientific software.
  • If the CI / Documentation check ends with a cryptic error message, check out our documentation troubleshooting guide.
  • For a documentation preview, click on Details next to docs/readthedocs.org:plasmapy.

If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder.

Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples.

We thank you once again!

@github-actions github-actions bot added the packaging Related to packaging or distribution label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7b9af31) 98.37% compared to head (14adae2) 98.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2256   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          99       99           
  Lines        8553     8553           
=======================================
  Hits         8414     8414           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the plasmapy.formulary Related to the plasmapy.formulary subpackage label Jul 26, 2023
@namurphy namurphy added this to the 2023.9.0 milestone Aug 2, 2023
@namurphy
Copy link
Member Author

namurphy commented Oct 4, 2023

Thinking more about this, it might be better to keep all of the Cython stuff packaged outside of core. I'm remembering back to astropy/astropy#7660, for example.

@namurphy namurphy closed this Oct 4, 2023
@namurphy namurphy deleted the cythonification branch October 4, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Related to packaging or distribution plasmapy.formulary Related to the plasmapy.formulary subpackage prototype 🏗️ Trying out an implementation on a trial basis requirements Related to updating requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant