Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize assets/manifest.json version with package.json #138

Merged
merged 1 commit into from
Jul 30, 2016

Conversation

josephfrazier
Copy link
Member

This was done with npm run version, which normally happens as part of
npm version (see #137)

It looks like the json command reformatted a couple of other fields,
but that should be a one-time thing, assuming we preserve the new
formatting with any manual changes we make in the future.

Once this is merged, we can tag it as v4.2.0 and try the release again,
as described in #137 (comment)

This was done with `npm run version`, which normally happens as part of
`npm version` (see OctoLinker#137)

It looks like the `json` command reformatted a couple of other fields,
but that should be a one-time thing, assuming we preserve the new
formatting with any manual changes we make in the future.

Once this is merged, we can tag it as `v4.2.0` and try the release again,
as described in OctoLinker#137 (comment)
@stefanbuck stefanbuck merged commit 1b86d99 into OctoLinker:master Jul 30, 2016
@stefanbuck
Copy link
Member

Go for it 😄

@josephfrazier josephfrazier deleted the fix-manifest branch July 30, 2016 23:56
@josephfrazier
Copy link
Member Author

Awesome, thanks! I submitted the Firefox/Opera versions from the Github release .zip files, as you mentioned in #136 (comment). Here they are:

I didn't see where to submit the Opera source code, though

@stefanbuck
Copy link
Member

Ahh right, there is no possibilty to upload ther source in the opera store (I should go to bed). Just post the tag zip link in the conversation tab and copy past the instrcution from below.

Good night and enjoy your weekend.

@josephfrazier
Copy link
Member Author

Ohhh, I see now. I took care of it. Thanks for all the help, and enjoy your weekend too!

josephfrazier added a commit to josephfrazier/browser-extension that referenced this pull request Jul 31, 2016
stefanbuck pushed a commit that referenced this pull request Aug 3, 2016
* Document the release process in CONTRIBUTING.md

These steps were assembled from the comments in:

* #136
* #137
* #138

* CONTRIBUTING.md: Add commit log link

See #139 (comment)
omadoww added a commit to omadoww/browser-extension that referenced this pull request Nov 20, 2024
* Document the release process in CONTRIBUTING.md

These steps were assembled from the comments in:

* OctoLinker/OctoLinker#136
* OctoLinker/OctoLinker#137
* OctoLinker/OctoLinker#138

* CONTRIBUTING.md: Add commit log link

See OctoLinker/OctoLinker#139 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants