Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2.0 #136

Merged
merged 1 commit into from
Jul 30, 2016
Merged

Release 4.2.0 #136

merged 1 commit into from
Jul 30, 2016

Conversation

josephfrazier
Copy link
Member

@josephfrazier josephfrazier commented Jul 30, 2016

See #135

@stefanbuck, as we've discussed privately, I'll take a shot at doing the releases for this one. Just to confirm, here are the steps that are needed (as far as I know):

@josephfrazier josephfrazier merged commit a6343e1 into OctoLinker:master Jul 30, 2016
@josephfrazier josephfrazier deleted the 4.2.0 branch July 30, 2016 22:28
@josephfrazier
Copy link
Member Author

Oops, I forgot to put the new version in assets/manifest.json! I was thinking that the code only contained "4.1.0", so I replaced only that within the codebase, which meant that I overlooked the 4.1.1 in assets/manifest.json. I'll follow up with a new PR for version 4.2.1, which will synchronize that version with the one in package.json.

@stefanbuck
Copy link
Member

Let's remove the version field from the package.json file. It's useless anyway since this is not a published npm module.

Regarding the required steps:

  • Travis should attach all build version chrome, firefox and opera to the release tag, so there is no need to run npm run package-all manually.
  • You also have to upload the source code for the code review process for firefox and opera.

@stefanbuck
Copy link
Member

To avoid the unessercy version bump you can also do a force push with the fixed version this time.

josephfrazier added a commit to josephfrazier/browser-extension that referenced this pull request Jul 30, 2016
`npm version` is an easy way to commit a new version, but it only
updates `package.json`. This script ensures that the version in
`assets/manifest.json` is kept in sync, to avoid a reoccurrence of
OctoLinker#136 (comment)

See here for details about `npm version` and its associated package.json
scripts: https://docs.npmjs.com/cli/version
josephfrazier added a commit to josephfrazier/browser-extension that referenced this pull request Jul 30, 2016
`npm version` is an easy way to commit a new version, but it only
updates `package.json`. This script ensures that the version in
`assets/manifest.json` is kept in sync, to avoid a reoccurrence of
OctoLinker#136 (comment)

See here for details about `npm version` and its associated package.json
scripts: https://docs.npmjs.com/cli/version
@stefanbuck
Copy link
Member

I disabled the branch protection and remove the release from GH.

stefanbuck pushed a commit that referenced this pull request Jul 30, 2016
`npm version` is an easy way to commit a new version, but it only
updates `package.json`. This script ensures that the version in
`assets/manifest.json` is kept in sync, to avoid a reoccurrence of
#136 (comment)

See here for details about `npm version` and its associated package.json
scripts: https://docs.npmjs.com/cli/version
josephfrazier added a commit to josephfrazier/browser-extension that referenced this pull request Jul 31, 2016
stefanbuck pushed a commit that referenced this pull request Aug 3, 2016
* Document the release process in CONTRIBUTING.md

These steps were assembled from the comments in:

* #136
* #137
* #138

* CONTRIBUTING.md: Add commit log link

See #139 (comment)
omadoww added a commit to omadoww/browser-extension that referenced this pull request Nov 20, 2024
`npm version` is an easy way to commit a new version, but it only
updates `package.json`. This script ensures that the version in
`assets/manifest.json` is kept in sync, to avoid a reoccurrence of
OctoLinker/OctoLinker#136 (comment)

See here for details about `npm version` and its associated package.json
scripts: https://docs.npmjs.com/cli/version
omadoww added a commit to omadoww/browser-extension that referenced this pull request Nov 20, 2024
* Document the release process in CONTRIBUTING.md

These steps were assembled from the comments in:

* OctoLinker/OctoLinker#136
* OctoLinker/OctoLinker#137
* OctoLinker/OctoLinker#138

* CONTRIBUTING.md: Add commit log link

See OctoLinker/OctoLinker#139 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants