Add a standalone LibStdCxx jll #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than trying to shoehorn the libstdcxx build into bootstrap as in #5308, just add a separate jll for it and in a follow-up PR, I'll adjust CSL to pull libstdcxx from here instead. In the medium term future, we may want to change this again, but for now, I think this is the path of least resistance.
Keno
force-pushed
the
kf/libstdcxxmsan2
branch
from
2456639 to
01b3974
Compare
|
Ok, this seems to be working for both gcc v11 and v12. The PR as is has v11. I'm thinking merge this and then immediately do a PR to bump to v12 so we have both, depending on the timing of the base CSL bump. Thoughts @staticfloat @giordano ? |
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to shoehorn the libstdcxx build into bootstrap as in #5308,
just add a separate jll for it and in a follow-up PR, I'll adjust CSL to pull
libstdcxx from here instead. In the medium term future, we may want to change
this again, but for now, I think this is the path of least resistance.