[WIP] Recipe to build libstdcxx with msan #5308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
Keno
added a commit
that referenced
this pull request
Aug 18, 2022
Rather than trying to shoehorn the libstdcxx build into bootstrap as in #5308, just add a separate jll for it and in a follow-up PR, I'll adjust CSL to pull libstdcxx from here instead. In the medium term future, we may want to change this again, but for now, I think this is the path of least resistance.
Keno
added a commit
that referenced
this pull request
Aug 19, 2022
* Add a standalone LibStdCxx jll Rather than trying to shoehorn the libstdcxx build into bootstrap as in #5308, just add a separate jll for it and in a follow-up PR, I'll adjust CSL to pull libstdcxx from here instead. In the medium term future, we may want to change this again, but for now, I think this is the path of least resistance. * disable aarch64 macos * Let's just do the sanitizer version
|
Closed in favor of #5331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be working in the sense that with the included patch, I've obtained a libstdc++ that can be dropped in for CSL on a julia-msan build and successfully gets rid of the libstdc++ induced false positives. @staticfloat could I ask you to figure out what the proper way to do this is and how to get a
-sanitize+memoryjll out of it in the end?