Change default argument values

JuliaLang · vtjnash · Mar 11, 2024 · Jan 22, 2024 · Feb 4, 2024 · Feb 8, 2024
commit d30c9c0766be40db124e3407a48457320299fdc3
diff --git a/base/task.jl b/base/task.jl
@@ -368,7 +368,7 @@ end
 # Wait multiple tasks
 
 """
-    waitany(tasks; throw=false) -> (done_tasks, remaining_tasks)
+    waitany(tasks; throw=true) -> (done_tasks, remaining_tasks)
 
 Wait until at least one of the given tasks have been completed.
 
@@ -378,10 +378,10 @@ completed tasks completes with an exception.
 The return value consists of two task vectors. The first one consists of
 completed tasks, and the other consists of uncompleted tasks.
 """
-waitany(tasks; throw=false) = _wait_multiple(tasks, throw)
+waitany(tasks; throw=true) = _wait_multiple(tasks, throw)
 
 """
-    waitall(tasks; failfast=false, throw=false) -> (done_tasks, remaining_tasks)
+    waitall(tasks; failfast=true, throw=true) -> (done_tasks, remaining_tasks)
 
 Wait until all the given tasks have been completed.
 
@@ -395,7 +395,7 @@ given tasks is finished by exception. If `throw` is `true`, throw
 The return value consists of two task vectors. The first one consists of
 completed tasks, and the other consists of uncompleted tasks.
 """
-waitall(tasks; failfast=false, throw=false) = _wait_multiple(tasks, throw, true, failfast)
+waitall(tasks; failfast=true, throw=true) = _wait_multiple(tasks, throw, true, failfast)
 
 function _wait_multiple(waiting_tasks, throwexc=false, all=false, failfast=false)
     tasks = Task[]

diff --git a/test/threads_exec.jl b/test/threads_exec.jl
@@ -1217,11 +1217,11 @@ end
 
     for tasks_type in (Vector{Task}, Set{Task}, Tuple{Task})
         @testset "waitany" begin
-            @testset "no options" begin
+            @testset "throw=false" begin
                 tasks, event = create_tasks()
                 wait(tasks[1])
                 wait(tasks[2])
-                done,  pending = waitany(convert_tasks(tasks_type, tasks))
+                done,  pending = waitany(convert_tasks(tasks_type, tasks); throw=false)
                 @test length(done) == 2
                 @test tasks[1] ∈ done
                 @test tasks[2] ∈ done
@@ -1260,13 +1260,13 @@ end
                 @test length(pending) == 0
             end
 
-            @testset "failfast=true" begin
+            @testset "failfast=true, throw=false" begin
                 tasks, event = create_tasks()
                 push!(tasks, Threads.@spawn error("Error"))
 
                 wait(tasks[1])
                 wait(tasks[2])
-                waiter = Threads.@spawn waitall(convert_tasks(tasks_type, tasks); failfast=true)
+                waiter = Threads.@spawn waitall(convert_tasks(tasks_type, tasks); failfast=true, throw=false)
 
                 done, pending = fetch(waiter)
                 @test length(done) == 3
@@ -1279,22 +1279,22 @@ end
                 teardown(tasks, event)
             end
 
-            @testset "throw=true" begin
+            @testset "failfast=false, throw=true" begin
                 tasks, event = create_tasks()
                 push!(tasks, Threads.@spawn error("Error"))
 
                 notify(event)
 
                 @test_throws CompositeException begin
-                    waitall(convert_tasks(tasks_type, tasks); throw=true)
+                    waitall(convert_tasks(tasks_type, tasks); failfast=false, throw=true)
                 end
 
                 @test all(istaskdone.(tasks))
 
                 teardown(tasks, event)
             end
 
-            @testset "failfast=true and throw=true" begin
+            @testset "failfast=true, throw=true" begin
                 tasks, event = create_tasks()
                 push!(tasks, Threads.@spawn error("Error"))