Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitany and waitall functions to wait multiple tasks at once #53341

Merged
merged 30 commits into from
Mar 11, 2024
Merged

Add waitany and waitall functions to wait multiple tasks at once #53341

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1fb6a95
Add waitany and waitall to wait multiple tasks
mrkn Jan 22, 2024
7482838
Reduce the number of working vectors
mrkn Feb 4, 2024
5a30999
Rewrite with using Channel
mrkn Feb 8, 2024
664f8a3
Add test cases to Cover all argument types
mrkn Feb 15, 2024
8ac6ddc
Remove return type of _wait_multiple
mrkn Feb 27, 2024
f459e8a
Remove 1st argument type of _wait_multiple
mrkn Feb 27, 2024
eb2bafd
Specify type of element that comes from iteration for type stability
mrkn Feb 27, 2024
d7cf9dc
Support inputs that can be iterated only once
mrkn Mar 1, 2024
9159247
Delete waiters from waitq of each remaining task
mrkn Mar 1, 2024
573ee9f
Fix for performance
mrkn Mar 1, 2024
1175779
Split type checking and examining loops
mrkn Mar 4, 2024
633cb58
Stop using needless enumerate
mrkn Mar 5, 2024
4bec8cd
Optimize for waitall with failfast=false
mrkn Mar 5, 2024
b9dd9e6
Use vector for managing waiters
mrkn Mar 5, 2024
ae0ca9d
Add channel emptiness check
mrkn Mar 5, 2024
93057e6
Insert done check in waiter creation loop
mrkn Mar 5, 2024
ed58eda
Stop using kwargs in _wait_multiple
mrkn Mar 6, 2024
f1f400e
Add throw keyword argument in waitall
mrkn Mar 6, 2024
4d8e137
Add throw keyword argument in waitany
mrkn Mar 6, 2024
1a55697
Add docstrings of waitany and waitall
mrkn Mar 7, 2024
22646dd
Wait single task synchronously
mrkn Mar 7, 2024
505d476
Use TaskFailedException
mrkn Mar 7, 2024
1c9adbf
Stop using sleep in test
mrkn Mar 7, 2024
58d1e02
Remove needless yield call
mrkn Mar 7, 2024
3c9a9c8
Wait all three tasks in teardown function in test
mrkn Mar 7, 2024
4dd8862
Use consistent declarative tense in docstring
mrkn Mar 7, 2024
34e3d41
Add waitany and waitall in doc/src/base/parallel.md
mrkn Mar 7, 2024
8a7683f
Add waitany and waitall in NEWS.md
mrkn Mar 7, 2024
d30c9c0
Change default argument values
mrkn Mar 8, 2024
0a382a3
Add usage note of waitall in docstring
mrkn Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Insert done check in waiter creation loop 
Co-authored-by: Jameson Nash <[email protected]>
  • Loading branch information
@mrkn @vtjnash
mrkn and vtjnash committed Mar 9, 2024
commit 93057e6c4ec2f2413d128367d153c64247d194ae
10 changes: 8 additions & 2 deletions base/task.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,14 @@ function _wait_multiple(waiting_tasks; all=false, failfast=false)
waiter_tasks = fill(sentinel, length(tasks))

for (i, done) in enumerate(done_mask)
if !done
t = tasks[i]
done && continue
t = tasks[i]
if istaskdone(t)
done_mask[i] = true
exception |= istaskfailed(t)
nremaining -= 1
exception && failfast && break
else
waiter = @task put!(chan, i)
waiter.sticky = false
_wait2(t, waiter)
Expand Down