add paths to file error messages #38242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Oct 30, 2020
|
fixes #38005 |
|
Also fixes #33236. |
|
Also #33201. |
simonbyrne
force-pushed
the
sb/file-errormsg
branch
from
476fe61 to
0891bc3
Compare
simonbyrne
force-pushed
the
sb/file-errormsg
branch
from
0891bc3 to
3fe5ea7
Compare
simonbyrne
force-pushed
the
sb/file-errormsg
branch
from
c37c664 to
c2603b1
Compare
simonbyrne
force-pushed
the
sb/file-errormsg
branch
from
c2603b1 to
fc7b55b
Compare
|
The FreeBSD failure seems unrelated, and the MacOS failure is on the "clean it out" stage: I suspect this could have been caused by the permissions changes in the builds for #38235. |
|
Okay, this is ready to go. |
|
Bump! A few minutes ago I wished this was already merged 😄 |
|
Seems like a huge improvement to me! I'm assuming that since these are all I/O operations none of them are performance sensitive enough that having error paths capture variables matters. |
StefanKarpinski
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the error messages for various file operations more descriptive, including the paths and other arguments.
EDIT: closes #38005, closes #33236, closes #33201.