Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS app: make julia directory read only #38235

Merged
merged 5 commits into from
Nov 2, 2020
Merged

Conversation

simonbyrne
Copy link
Contributor

Fix #38146.

@simonbyrne simonbyrne added the system:mac Affects only macOS label Oct 30, 2020
simonbyrne added a commit to JuliaWeb/LibCURL.jl that referenced this pull request Nov 1, 2020
This is required to make the Julia directory read-only (JuliaLang/julia#38235)
@simonbyrne
Copy link
Contributor Author

simonbyrne commented Nov 1, 2020

This requires JuliaWeb/LibCURL.jl#92 to be merged and the version of LibCURL to be updated.

simonbyrne added a commit to JuliaWeb/LibCURL.jl that referenced this pull request Nov 2, 2020
This is required to make the Julia directory read-only (JuliaLang/julia#38235)
@simonbyrne
Copy link
Contributor Author

I've merged the LibCURL PR, how do I update the stdlib?

@StefanKarpinski
Copy link
Member

I use this shell incantation run from the git repo of the stdlib that you want to bump:

pkg=LibCURL; ver=HEAD; echo "$(echo -n $pkg | tr a-z A-Z)_BRANCH = $(git rev-parse --symbolic-full-name HEAD | perl -ple 's{^refs/heads/}{}')\n$(echo -n $pkg | tr a-z A-Z)_SHA1 = $(git rev-parse $ver)" > ~/dev/julia/stdlib/$pkg.version

Then you have to go into ~/dev/julia (or wherever you keep your Julia repo) and do git rm -r deps/checksums/$pkg-*, run make and add the new checksums. Taken all together, that's what goes in the PR.

@staticfloat staticfloat merged commit 961ec0d into master Nov 2, 2020
@staticfloat staticfloat deleted the sb/macos-readonly branch November 2, 2020 20:13
simonbyrne added a commit that referenced this pull request Nov 3, 2020
#38235 appears to cause problems
- it seems to break GitHub Actions: https://github.com/JuliaParallel/MPI.jl/runs/1345656760?check_suite_focus=true#step:4:33
- it now requires a password to upgrade a patch release (which replace the `/Applications/Julia-1.6.app` directory)

It might be possible to fix th
simonbyrne added a commit that referenced this pull request Nov 3, 2020
PR #38235 seemed to cause problems:

- it seems to break GitHub Actions: https://github.com/JuliaParallel/MPI.jl/runs/1345656760?check_suite_focus=true#step:4:33
- it now requires a password to upgrade a patch release (which replace the `/Applications/Julia-1.6.app` directory)

This makes only the files read-only, which should solve the problem
staticfloat pushed a commit that referenced this pull request Nov 3, 2020
PR #38235 seemed to cause problems:

- it seems to break GitHub Actions: https://github.com/JuliaParallel/MPI.jl/runs/1345656760?check_suite_focus=true#step:4:33
- it now requires a password to upgrade a patch release (which replace the `/Applications/Julia-1.6.app` directory)

This makes only the files read-only, which should solve the problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard library files writeable on Mac
3 participants