Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructors #26

Merged
merged 4 commits into from
Nov 8, 2019
Merged

Constructors #26

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04ff4db
put types into their own file and add constructor from other type
mileslucas Oct 18, 2019
3491fee
add tests and write code allowing unit conversion with pipe
mileslucas Oct 19, 2019
ee418f0
rebase branch and add version
mileslucas Oct 21, 2019
73c9a3e
add conversion docs to documentation
mileslucas Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase branch and add version
  • Loading branch information
@mileslucas
mileslucas committed Nov 6, 2019
commit ee418f0c54969fbfe73526d924cd5b9f06deb7db
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SkyCoords"
uuid = "fc659fc5-75a3-5475-a2ea-3da92c065361"
authors = "Kyle Barbary, Mosé Giordano, and contributors"
version = "0.4.0"
version = "0.5.0-DEV"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can directly use 0.5.0 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have plans for another PR after this one to allow string construction, which is mostly written already so it could make sense to push that one as 0.5.0


[deps]
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
Expand Down
22 changes: 0 additions & 22 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,3 @@ end
@test separation(c3, c6) ≈ separation(c6, c3) ≈ 1
end
end

# @testset "Pre-conversion of inputs" begin
# # Constructor of FK5Coords{1950} with non-float arguments
# @test typeof(FK5Coords{1950}(1, big(2))) == FK5Coords{1950,BigFloat}

# # Unitful
# @test ICRSCoords(20u"°", 0u"rad") == ICRSCoords(0.3490658503988659, 0.0)
# @test GalCoords(20u"°", 0u"rad") == GalCoords(0.3490658503988659, 0.0)
# @test FK5Coords{2000}(20u"°", 0u"rad") == FK5Coords{2000}(0.3490658503988659, 0.0)
# end

# @testset "Coord String" begin
# @test coord"0h0m0s" == coord"0°0'0\"" == 0.0
# @test coord"12h0m0s" ≈ coord"180°0'0\"" ≈ π
# @test coord"-12h0m0s" ≈ coord"-180°0'0\"" ≈ -π
# @test coord"+12h0m0s" ≈ coord"+180°0'0\"" ≈ π
# @test coord"18h36m56.33635s" ≈ 4.873565508047745
# @test coord"38°47'01.2802\"" ≈ 0.6769030681498798
# @test coord"- 10° 02' 10.885 \"" ≈ -0.17389837681291273
# @test coord"2 h 12 m 33.33 s" ≈ 0.5783824791568358
# @test_throws LoadError eval(:(coord"02 50 1242.444"))
# end