Constructors #26
Merged
Constructors #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
- Coverage 89.65% 86.36% -3.3%
=========================================
Files 1 2 +1
Lines 58 66 +8
=========================================
+ Hits 52 57 +5
- Misses 6 9 +3
Continue to review full report at Codecov.
|
giordano
reviewed
Nov 7, 2019
| @@ -1,7 +1,7 @@ | |||
| name = "SkyCoords" | |||
| uuid = "fc659fc5-75a3-5475-a2ea-3da92c065361" | |||
| authors = "Kyle Barbary, Mosé Giordano, and contributors" | |||
| version = "0.4.0" | |||
| version = "0.5.0-DEV" | |||
There was a problem hiding this comment.
I think we can directly use 0.5.0 here.
There was a problem hiding this comment.
I have plans for another PR after this one to allow string construction, which is mostly written already so it could make sense to push that one as 0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some extra constructors. This depends on #25 to be merged first, so I will leave it as a draft until then.
I've added some constructors that follow this syntax
which can also allow the convenient piping syntax
I know the piping syntax is somewhat controversial, but I think for these type conversions it is a really clean way to signify the conversion. I really like its usage in Unitful, for example.
So far I've added the appropriate constructors for each type and added in tests to check they are converted in the same way as
Base.convertdoes. As it stands, there might be interest in adding some sort of metaprogramming to write these constructors since they are somewhat consistent across all types (although not perfect because of the equinox parameter for FK5).I've incremented version to
0.5.0-dev