Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs runtime for creating cloud functions #697

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

q2w
Copy link
Contributor

@q2w q2w commented Dec 21, 2023

The nodejs8 runtime is no longer supported for cloud function. Thic PR upgrades from nodejs8 to nodejs18 (which is recommended). More about cloud function runtime here

Copy link

google-cla bot commented Dec 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@q2w q2w marked this pull request as ready for review December 21, 2023 16:58
@q2w q2w closed this Dec 21, 2023
@q2w q2w reopened this Dec 21, 2023
Copy link
Contributor

@karutselvan karutselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karutselvan karutselvan merged commit 5b660b8 into GoogleCloudPlatform:master Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants