Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Require vimeo/psalm instead of psalm/phar #139

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fix: Require vimeo/psalm instead of psalm/phar #139

merged 1 commit into from
Dec 11, 2020

Conversation

localheinz
Copy link
Member

This PR

  • requires vimeo/psalm instead of psalm/phar

💁‍♂️ We are already using bamarni/composer-bin-plugin to avoid conflicts.

@localheinz localheinz added the bug Something isn't working label Dec 11, 2020
@localheinz localheinz self-assigned this Dec 11, 2020
@localheinz localheinz changed the title Fix: Require vimeo/psalm Fix: Require vimeo/psalm instead of psalm/phar Dec 11, 2020
@localheinz localheinz merged commit 00d0fe1 into FakerPHP:main Dec 11, 2020
@localheinz localheinz deleted the fix/psalm branch December 11, 2020 12:38
@GrahamCampbell
Copy link
Member

This is a bad idea since subdeps are not fixed.

@localheinz
Copy link
Member Author

@GrahamCampbell

See #137.

@GrahamCampbell
Copy link
Member

Should just revert everything imo. Was better before. Less noisey changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @GrahamCampbell