Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Check in composer.lock for development tools #137

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Enhancement: Check in composer.lock for development tools #137

merged 1 commit into from
Dec 11, 2020

Conversation

localheinz
Copy link
Member

This PR

  • checks in composer.lock for development tools

Follows #131.

@localheinz localheinz self-assigned this Dec 11, 2020
@localheinz localheinz added the enhancement New feature or request label Dec 11, 2020
@localheinz localheinz merged commit f8e5ebc into FakerPHP:main Dec 11, 2020
@localheinz localheinz deleted the feature/lock branch December 11, 2020 12:20
@mfn
Copy link

mfn commented Dec 11, 2020

Why would we want that?

@localheinz
Copy link
Member Author

@mfn

Because:

  • we want to use Dependabot
  • we want reproducible builds

@mfn
Copy link

mfn commented Dec 11, 2020

@localheinz thank you!

@localheinz localheinz mentioned this pull request Dec 11, 2020
Merged
1 task
@localheinz
Copy link
Member Author

@mfn

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @mfn