Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics: keep deleted feeds #1960

Closed
keunes opened this issue May 27, 2016 · 10 comments
Closed

Statistics: keep deleted feeds #1960

keunes opened this issue May 27, 2016 · 10 comments
Labels
Needs: Triage The core team still needs to decide if this feature would get accepted Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one

Comments

@keunes
Copy link
Member

keunes commented May 27, 2016

Currently, when feeds get deleted they also get removed from the statistics section. There may be several reasons to still keep that statistic:

  • the publisher changes the url without any forward mechanism/update in a directory (to get the right number one might want to add up two feeds)
  • one deletes an old feed but still wants to keep that statistic (for whatever reason)

So imho it would be nice if the statistics for deleted feeds would be maintained, or at least removal of statistics is decoupled from removal of the feed (until statistics get reset (#1869)).

@mfietz
Copy link
Contributor

mfietz commented May 27, 2016

A feed has items and items have media. Currently, we calculate the played duration from these media. To keep statistics about deleted feeds, we would have to keep all of this data in the database with the current model (and mark the feed as deleted).
And I'd assume some other people explicitly would not want to have deleted feeds included in the statistics - This would get complicated really quickly.

The first argument could be resolved if people could choose to not only include actually played duration, but also the complete duration (which maybe has been played only partially) once the episode has been marked as played (changed in #1841)

@keunes
Copy link
Member Author

keunes commented May 27, 2016

Currently, we calculate the played duration from these media. To keep statistics about deleted feeds, we would have to keep all of this data in the database with the current model

Can imagine we don't want to keep database items of deleted feeds. I thought that upon deletion an entry in a separate table or sth could be created that stores the total played time + name of deleted feeds. This data can then be merged into the total statistics table. (don't laugh at me now for being noob)

@mfietz mfietz added the Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one label Jun 3, 2016
@keunes
Copy link
Member Author

keunes commented Aug 19, 2019

Reading #2489, I was thinking that instead of 'deletion' we could add a feed's settings 'hide from menu' in addition to the 'keep updated' setting, to sort of achieve the goal of this issue. Except that such approach would mean this feed takes up (unnecessary) data.

@ByteHamster
Copy link
Member

I was thinking that instead of 'deletion' we could add a feed's settings 'hide from menu'

Hmm instead of doing this, I would rather vote for the ability to add folders (#1711). Then users can put all those podcasts into a single folder. Hiding from menu then requires an additional screen that allows to bring them back.

@keunes
Copy link
Member Author

keunes commented Aug 23, 2019

Hiding from menu then requires an additional screen that allows to bring them back.

We already have that screen: 'Subscriptions'

But yeah, the folder option could also be a work-around for delete-except-stats.

@unsungNovelty
Copy link

unsungNovelty commented Nov 6, 2020

Hi,
Appreciate all the work on Antennapod, it really is the best available podcast player!

I understand this is not a trivial feature to have, but I would really appreciate if this is taken into consideration since I use it regularly.

How I see this as a bug:

  • The statistics page is supposed to show the full stats of the duration periods for individual podcast subscriptions. The current implementation of statistics page falls short in providing this context since deleting a podcast feed removes the stats of that podcast.
  • A human error of accidentally removing the feed also removes the statistical context of the podcast currently.

How I use stats page:

  • I use the stats page to get an understanding of how much more hours I have to listen to catch up on a particular podcast. Extremely useful for podcasts which needs to be listened sequentially.
  • I use stats page in regular intervals of time to gauge the quality of a podcast or my subscriptions or my listening habits over time to prioritise better.
  • Also it's just really a rewarding mechanism to see really. It kind of makes me listen to more podcasts. Also helps give context on podcasts to which you are coming back after a long time.

Hope this helps in some way to understand it better.

cc:// @ByteHamster

@keunes keunes mentioned this issue Nov 29, 2020
@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/statistics-inconsistency-after-podcast-deletion/460/2

@chromer030
Copy link

+1 for this feature.

@ByteHamster , please consider an option to keep statistics of removed feeds/episodes , especially the local ones.

@AntennaPod AntennaPod locked and limited conversation to collaborators Feb 15, 2023
@keunes
Copy link
Member Author

keunes commented Feb 15, 2023

Locking to avoid further "+1" comments. Needs and interest are clear. Unfortunately this also means upvoting is no longer possible (request to GitHub to correct this).

@ByteHamster ByteHamster added the Needs: Triage The core team still needs to decide if this feature would get accepted label Feb 29, 2024
@keunes
Copy link
Member Author

keunes commented Dec 22, 2024

We discussed again when reviewing our list of open issues, and concluded that (because of the statistics) it doesn't make sense to implement this. Instead, archiving is the way to go (#6672).

@keunes keunes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Triage The core team still needs to decide if this feature would get accepted Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one
Projects
None yet
Development

No branches or pull requests

6 participants