-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): Switch from yarn v3 to pnpm #92
Conversation
Rate Limit Exceeded@AdiRishi has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 14 minutes and 56 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, convert this PR to a draft and then mark it as ready for review again to re-trigger the review. Alternatively, you can push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per repository. WalkthroughThis pull request primarily focuses on transitioning the project's package management from Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files ignored due to filter (3)
- package.json
- pnpm-lock.yaml
- yarn.lock
Files selected for processing (4)
- .github/CONTRIBUTING.md (1 hunks)
- .github/workflows/ci.yml (1 hunks)
- .github/workflows/deploy.yml (1 hunks)
- README.md (3 hunks)
Files skipped from review due to trivial changes (3)
- .github/CONTRIBUTING.md
- .github/workflows/ci.yml
- README.md
Additional comments (Suppressed): 3
.github/workflows/deploy.yml (3)
14-17: The
pnpm/action-setup@v2
action is used to set up pnpm, but the version specified is 8. Please verify if this is the intended version of pnpm to be used.20-20: Good job on updating the cache option from 'yarn' to 'pnpm'. This will ensure that the correct package manager's cache is used.
21-21: The command for installing dependencies has been correctly updated from
yarn install
topnpm install
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Files selected for processing (1)
- .github/workflows/deploy.yml (1 hunks)
Additional comments (Suppressed): 2
.github/workflows/deploy.yml (2)
7-8: The
deploy.yml
workflow now triggers on pull requests targeting themaster
branch. This is a significant change and could potentially lead to deployments happening more frequently than intended, especially if your team creates a lot of pull requests. Please verify that this is the desired behavior.16-18: You are using
pnpm/action-setup@v2
to set up pnpm with version 8. Ensure that all dependencies of your project are compatible with this version of pnpm.
.github/workflows/deploy.yml
Outdated
- name: Deploy | ||
uses: cloudflare/wrangler-action@v3 | ||
uses: cloudflare/wrangler-action@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have changed the version of cloudflare/wrangler-action
from v3
to master
. Using the master
branch can be risky as it may contain unstable changes. Consider pinning to a specific stable version or a release tag.
Rate Limit ExceededYou have exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 29 minutes and 59 seconds before requesting another review. To re-trigger a review, convert this PR to a draft and then mark it as ready for review again. Alternatively, you can push a new commit to this PR. |
09c4a74
to
93a018e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files ignored due to filter (3)
- package.json
- pnpm-lock.yaml
- yarn.lock
Files selected for processing (4)
- .github/CONTRIBUTING.md (1 hunks)
- .github/workflows/ci.yml (1 hunks)
- .github/workflows/deploy.yml (1 hunks)
- README.md (3 hunks)
Files skipped from review due to trivial changes (4)
- .github/CONTRIBUTING.md
- .github/workflows/ci.yml
- .github/workflows/deploy.yml
- README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files ignored due to filter (3)
- package.json
- pnpm-lock.yaml
- yarn.lock
Files selected for processing (4)
- .github/CONTRIBUTING.md (1 hunks)
- .github/workflows/ci.yml (1 hunks)
- .github/workflows/deploy.yml (1 hunks)
- README.md (3 hunks)
Files skipped from review due to trivial changes (3)
- .github/CONTRIBUTING.md
- .github/workflows/ci.yml
- README.md
Additional comments (Suppressed): 2
.github/workflows/deploy.yml (2)
14-16: The
pnpm/action-setup@v2
action is used to set up PNPM. Ensure that the version specified (8) is compatible with the project's dependencies and does not introduce breaking changes.20-21: The cache option has been updated from 'yarn' to 'pnpm', and the command for installing dependencies has been changed from
yarn install
topnpm install
. Verify that these changes have been reflected in all relevant parts of the codebase, including documentation and scripts.
This reverts commit 1b24811.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #84
Summary by CodeRabbit
Chore:
yarn
topnpm
as the package manager across all project files and documentation for improved package management and dependency resolution.ci.yml
anddeploy.yml
) to usepnpm
for installing dependencies, linting, type checking, building, and testing.deploy.yml
to run the workflow on pull requests targeting themaster
branch.Documentation:
README.md
and.github/CONTRIBUTING.md
to reflect the switch topnpm
.README.md
and.github/CONTRIBUTING.md
to usepnpm
.