Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements and fixes #1817

Merged
merged 8 commits into from
May 25, 2021
Merged

Various improvements and fixes #1817

merged 8 commits into from
May 25, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented May 21, 2021

This PR contains many small commits that fix various issues I found looking at our node's logs for the past month.
All commits are independent and should be reviewed separately; each commit description details what is improved/fixed.

@t-bast t-bast requested a review from pm47 May 21, 2021 07:58
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #1817 (60655e5) into master (98cae45) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   89.39%   89.36%   -0.04%     
==========================================
  Files         145      145              
  Lines       11034    11044      +10     
  Branches      456      476      +20     
==========================================
+ Hits         9864     9869       +5     
- Misses       1170     1175       +5     
Impacted Files Coverage Δ
...cinq/eclair/blockchain/watchdogs/ExplorerApi.scala 54.28% <0.00%> (ø)
...src/main/scala/fr/acinq/eclair/crypto/Sphinx.scala 100.00% <ø> (ø)
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.13% <33.33%> (-0.29%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.87% <100.00%> (+0.07%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 90.52% <100.00%> (+0.63%) ⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala 90.68% <100.00%> (+0.05%) ⬆️
...r/acinq/eclair/payment/send/PaymentLifecycle.scala 92.90% <100.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala 90.76% <0.00%> (-1.54%) ⬇️
... and 1 more

* Reduce log level for explorer API errors
* Reduce log level for remote peer invalid open_channel
If there is already a pending HTLC settlement command in the DB, the
post-restart handler should let the channel replay it instead of sending
a conflicting command.
Sometimes lnd sends announcement_signatures before sending their channel
reestablish. This is a minor spec violation, we can simply delay the message
and handle it later (hopefully once we've received their reestablish).
Breez sometimes returns errors that we fail to parse.
Unfortunately we didn't correctly log the shared secrets because the
variable was shadowed, so we can't investigate further for now.
If we're unable to fetch the number of unconfirmed parents for a utxo,
this shouldn't cause the global utxo check to fail. We log a warning and
let operations continue to ensure the metric is updated.
We're seeing some instances of the following error in our logs:

cannot parse returned error: class fr.acinq.eclair.wire.protocol.UnknownMessage
cannot be cast to class fr.acinq.eclair.wire.protocol.ChannelUpdate

Logging the bytes and shared secrets will let us investigate these.
There may be a race condition where a peer disconnect in the middle of a
channel id assignment. In that case, we still want to record the up-to-date
mapping.
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits.

@t-bast t-bast merged commit e8c33ba into master May 25, 2021
@t-bast t-bast deleted the various-improvements branch May 25, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants