Better handling of TemporaryChannelFailure #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node returns a TemporaryChannelFailure, we should ignore this channel when retrying. In some cases (such as channels from routing hints) this was not correctly handled. Fixes #1725
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
=======================================
Coverage 86.29% 86.30%
=======================================
Files 151 151
Lines 11717 11723 +6
Branches 486 484 -2
=======================================
+ Hits 10111 10117 +6
Misses 1606 1606
|
pm47
approved these changes
Mar 10, 2021
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 21, 2021
When a node returns a TemporaryChannelFailure, we should ignore this channel when retrying. In some cases (such as channels from routing hints) this was not correctly handled. Fixes ACINQ#1725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node returns a TemporaryChannelFailure, we should ignore this channel when retrying. In some cases (such as channels from routing hints) this was not correctly handled.
We have a mechanism to send a node-wise exclusion to the
Router(only forChannelDisabled) but I think having a ceinture/bretelles solution makes sense.Fixes #1725