Refactor bitcoin clients #1697
Merged
Refactor bitcoin clients #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And improve test coverage specifically for the calls we'll rely on for CPFP and RBF.
pm47
reviewed
Feb 19, 2021
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/rpc/ExtendedBitcoinClient.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And improve test coverage specifically for the calls we'll rely on for CPFP and RBF.
I wanted to separate this PR from the one that actually use these calls for RBF/CPFP to avoid a monster PR, as these refactoring/clean-ups make sense anyway.
I also split a test in the
ElectrumWatcherSpecinto two tests because it was a bit flaky (block count synchronization betweenbitcoindandelectrumin the test suite is a bit flaky when a test generates multiple blocks in a sequence).