Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/meaningful auth errors cli 575 #5605

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat/meaningful auth errors cli 575 #5605

wants to merge 4 commits into from
+59 −21

Conversation

CatalinSnyk
Copy link

@CatalinSnyk CatalinSnyk commented Nov 27, 2024 •
edited
Loading

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

What are the relevant tickets?

@CatalinSnyk CatalinSnyk force-pushed the feat/meaningful-auth-errors-CLI-575 branch 2 times, most recently from b810052 to d50a28d Compare November 28, 2024 08:32
@PeterSchafer PeterSchafer force-pushed the feat/meaningful-auth-errors-CLI-575 branch from 8f12717 to 250fd82 Compare December 4, 2024 08:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Fails
🚫

"feat/meaningful auth errors cli 575" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 250fd82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CatalinSnyk