Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Restructure RangeIndexAttributeCondition #5259

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[refactor] Restructure RangeIndexAttributeCondition #5259

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2cb5349
[refactor] RangeIndexConfigAttributeCondition for readability
line-o Mar 22, 2024
9acc554
[ignore] fix formatting in RangeIndexConfigAttributeCondition
line-o Mar 22, 2024
3922b4d
[refactor] radical restructuring RangeIndexConfigAttributeCondition
line-o Mar 22, 2024
afb3bdd
[bugfix] add missing dependency to rang index POM
line-o Mar 26, 2024
fdfa924
[ignore] address code review
line-o Mar 28, 2024
51812e1
[refactor] make fields final in ComplexRangeIndexConfigElement
line-o Mar 28, 2024
4175cb5
[refactor] address SonarCloud warnings
line-o Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[refactor] address SonarCloud warnings
  • Loading branch information
@line-o
line-o committed Mar 28, 2024
commit 4175cb5c073033acd5e20cd304a95d8444f165a8
4 changes: 2 additions & 2 deletions ...exes/range/src/main/java/org/exist/indexing/range/RangeIndexConfigAttributeCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ static Predicate<AtomicValue> throwingPredicateWrapper(
try {
return throwingPredicate.test(v);
} catch (XPathException e) {
RangeIndex.LOG.error("Value conversion error when testing predicate for condition, value: {}", v.toString());
RangeIndex.LOG.error("Value conversion error when testing predicate for condition, value: {}", v);
RangeIndex.LOG.error(e);
return false;
}
Expand Down Expand Up @@ -343,7 +343,7 @@ private boolean compare(final GeneralComparison generalComparison) {
}
}

return currentOperator.equals(operator) && canTest(testStep, testValue) && queryPredicate.test(testValue);
return operator.equals(currentOperator) && canTest(testStep, testValue) && queryPredicate.test(testValue);
}

private boolean canTest (final LocationStep step, final AtomicValue value) {
Expand Down
Loading