[refactor] Restructure RangeIndexAttributeCondition #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only keep operator and two flags in memor - value, lowercasevalue and numericvalue were replaced by two functions - indexPredicate and queryPredicate
reinhapa
requested changes
Mar 27, 2024
...indexes/range/src/main/java/org/exist/indexing/range/RangeIndexConfigAttributeCondition.java
Outdated
Show resolved
Hide resolved
dizzzz
approved these changes
Mar 28, 2024
|
dizzzz
approved these changes
Apr 24, 2024
|
@reinhapa I believe the changes you requested were addressed in the meantime |
|
@reinhapa could you please re-review, I believe it's good to go |
adamretter
suggested changes
May 23, 2024
There was a problem hiding this comment.
I am not sure if this also addresses a bug or not? If it is just refactoring of existing code, then I have concerns:
- The newer code is more complex and difficult to follow; I don't see what advantage it offers over the existing code.
- The newer code exhibits symptoms of "information hiding". e.g. the variable
caseSensitive(amongst others) is no longer knowable within an instance of the class at runtime; one side effect of that is that it will make debugging any future issues much more difficult. - I haven't tested it with JMH myself, but my intuition is that the new code will perform worse that the older code. Has this been tested with JMH yet?
| } | ||
| operator = getOperator(elem); | ||
| commutative = (operator == Operator.EQ || operator == Operator.NE); | ||
| commutativeNegate = (operator == Operator.GT || operator == Operator.LT || operator == Operator.GE || operator == Operator.LE); |
There was a problem hiding this comment.
commutativeNegate is a very strange name, at least in English. Perhaps notCommutative would be better to describe what you are trying to model?
|
commutativeNegate could be renamed to converse (see https://en.m.wikipedia.org/wiki/Converse_relation and https://en.m.wikipedia.org/wiki/Inequality_(mathematics) ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These private properties of RangeIndexAttributeCondition
were replaced by
indexPredicate and queryPredicate are references to one-line lambdas.
Before, a lot of switching and checking happened on each call to
findandmatches