loading reading lists ...
');
function adjustReadingListIcon(isInReadingList){
$readingListToggle.toggleClass("fa-plus", !isInReadingList);
$readingListToggle.toggleClass("fa-check", isInReadingList);
var tooltipMessage = isInReadingList ? "edit in reading lists" : "add to reading list";
$readingListToggle.attr("title", tooltipMessage);
$readingListToggle.attr("data-original-title", tooltipMessage);
}
$.ajax({
url: "/readingList/isInReadingList",
data: {
productId: 2977
}
}).done(function (data) {
adjustReadingListIcon(data && data.hasProductInReadingList);
}).catch(function(e){
console.log(e);
adjustReadingListIcon(false);
});
$readingListToggle.on("click", function(){
if(codePromise == null){ showToast() }
loadCode().then(function(store){
store.requestReadingListSpecificationForProduct({
id: window.readingListsServerVars.externalId,
manningId: window.readingListsServerVars.productId,
title: window.readingListsServerVars.title
});
ReadingLists.ReactDOM.render(
ReadingLists.React.createElement(ReadingLists.ManningOnlineReadingListModal, {
store: store,
}),
document.getElementById("reading-lists-modal")
);
}).catch(function(e){
console.log("Error loading code reading list code");
});
});
var codePromise
var readingListStore
function loadCode(){
if(codePromise) { return codePromise }
return codePromise = new Promise(function (resolve, reject){
$.getScript(window.readingListsServerVars.libraryLocation).done(function(){
hideToast()
readingListStore = new ReadingLists.ReadingListStore(
new ReadingLists.ReadingListProvider(
new ReadingLists.ReadingListWebProvider(
ReadingLists.SourceApp.marketplace,
getDeploymentType()
)
)
);
readingListStore.onReadingListChange(handleChange);
readingListStore.onReadingListModalChange(handleChange);
resolve(readingListStore);
}).catch(function(){
hideToast();
console.log("Error downloading reading lists source");
$readingListToggle.css("display", "none");
reject();
});
});
}
function handleChange(){
if(readingListStore != null) {
adjustReadingListIcon(readingListStore.isInAtLeastOneReadingList({
id: window.readingListsServerVars.externalId,
manningId: window.readingListsServerVars.productId
}));
}
}
var $readingListToast = $("#reading-list-toast");
function showToast(){
$readingListToast.css("display", "flex");
setTimeout(function(){
$readingListToast.addClass("shown");
}, 16);
}
function hideToast(){
$readingListToast.removeClass("shown");
setTimeout(function(){
$readingListToast.css("display", "none");
}, 150);
}
function getDeploymentType(){
switch(window.readingListsServerVars.deploymentType){
case "development":
case "test":
return ReadingLists.DeploymentType.dev;
case "qa":
return ReadingLists.DeploymentType.qa;
case "production":
return ReadingLists.DeploymentType.prod;
case "docker":
return ReadingLists.DeploymentType.docker;
default:
console.error("Unknown deployment environment, defaulting to production");
return ReadingLists.DeploymentType.prod;
}
}
});
}
});
Constructive code reviews
pro $24.99 per month
- access to all Manning books, MEAPs, liveVideos, liveProjects, and audiobooks!
- choose one free eBook per month to keep
- exclusive 50% discount on all purchases
lite $19.99 per month
- access to all Manning books, including MEAPs!
team
5, 10 or 20 seats+ for your team - learn more
Look inside
Deliver code reviews that consistently build up your team and improve your applications.
“Looks Good to Me” offers a unique approach to delivering meaningful code reviews that goes beyond superficial checklists and tense critical conversations. Instead, you’ll learn how to improve both your applications and your team dynamics.
“Looks Good to Me” teaches you how to:
Inside “Looks Good to Me” you’ll find comprehensive coverage of every part of the code review process, from choosing a system to keeping reviews manageable for everyone involved. With this mix of tools, processes, common sense, and compassion, you’ll run a highly effective review process from first commit to final deployment.
“Looks Good to Me” offers a unique approach to delivering meaningful code reviews that goes beyond superficial checklists and tense critical conversations. Instead, you’ll learn how to improve both your applications and your team dynamics.
“Looks Good to Me” teaches you how to:
- Understand a code review's benefits proactively prevent loopholes and bottlenecks
- Co-create an objective code review system
- Clarify responsibilities: author, reviewer, team lead/manager, and the team itself
- Establish manageable guidelines and protocols
- Align with your team and explicitly document the policies they will follow
- Automate code quality with linting, formatting, static analysis, and automated testing
- Compose effective comments for any situation
- Consider combining code reviews with pair programming or mob programming
- AI for code reviews
Inside “Looks Good to Me” you’ll find comprehensive coverage of every part of the code review process, from choosing a system to keeping reviews manageable for everyone involved. With this mix of tools, processes, common sense, and compassion, you’ll run a highly effective review process from first commit to final deployment.
about the technology
Transform code reviews into the positive, productive experiences they’re meant to be! Whether it’s your code under the microscope or you’re the one giving the feedback, this sensible guide will help you avoid the tense debates, fruitless nitpicking, and unnecessary bottlenecks you’ve come to expect from code reviews.about the book
“Looks Good to Me” teaches the considerate, common sense approach to code reviews pioneered by author Adrienne Braganza. You’ll learn how to create a cohesive team environment, align review goals and expectations clearly, and be prepared for any changes or obstacles you may face. Along the way, you’ll master practices that adapt to how your team does things, with multiple options and solutions, relatable scenarios, and personal tidbits. You’ll soon be running highly effective reviews that make your code—and your team—stronger.Boldly tackles the human side of code reviews and shifts the narrative to empathy, respect, and constructive feedback.
Shines a spotlight on patterns that can make or break your team. Be prepared to do some self-reflection and decide what kind of developer you want to be.
A comprehensive overview of code review approaches, pitfalls, and how to ship higher-quality software.
A refreshing, human-centric approach to code reviews. I highly recommend it!
"Looks Good to Me" ebook for free
