feat: provide current factory to after/before hooks #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Dec 10, 2024
| // $attributes is what will be used to instantiate the object, manipulate as required | ||
| // $class is the class of the object being instantiated |
There was a problem hiding this comment.
I'm not sure why we're passing the $class here 🤔
There was a problem hiding this comment.
Me either... I think it was in case someone had some kind of beforeInstantiate object/service that could act on many different objects?
nikophil
commented
Dec 10, 2024
| /** | ||
| * @author Nicolas Philippe <[email protected]> | ||
| */ | ||
| final class FactoryWithHooksInInitializeTest extends KernelTestCase |
There was a problem hiding this comment.
I did not find any other class to put this test (we need a KernelTestCase, so that ->isPersisting() can return true)
nikophil
changed the title
nikophil
force-pushed
the
feat/provide-factory-to-hooks
branch
from
86e6c74 to
6f92f5d
Compare
nikophil
force-pushed
the
feat/provide-factory-to-hooks
branch
from
6f92f5d to
8a6b5a7
Compare
kbond
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #677